Changeset 0dbd4a9 in mainline for uspace/srv/bd/hr/metadata/native.c

Timestamp:

2025-06-28T22:52:18Z (9 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

9c9955ab

Parents:

2192a01

Message:

hr: metadata: validate magic early in decode

File:

• uspace/srv/bd/hr/metadata/native.c (modified) (3 diffs)

uspace/srv/bd/hr/metadata/native.c

@@ -116 +116 @@
                 goto error;
 
-        if (!meta_native_has_valid_magic(metadata_struct)) {
-                rc = ENOFS;
-                goto error;
-        }
-
         *rmd = metadata_struct;
         return EOK;
@@ -126 +121 @@
 error:
         free(metadata_struct);
-        return ENOFS;
+        return rc;
 }
 
@@ -440 +435 @@
 
         memcpy(metadata->magic, scratch_md.magic, HR_NATIVE_MAGIC_SIZE);
+        if (!meta_native_has_valid_magic(metadata))
+                return EINVAL;
+
         memcpy(metadata->uuid, scratch_md.uuid, HR_NATIVE_UUID_LEN);