Changeset 0dbd4a9 in mainline for uspace/srv/bd/hr/metadata/foreign/md/hr_md.c

Timestamp:

2025-06-28T22:52:18Z (9 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

9c9955ab

Parents:

2192a01

Message:

hr: metadata: validate magic early in decode

File:

• uspace/srv/bd/hr/metadata/foreign/md/hr_md.c (modified) (4 diffs)

uspace/srv/bd/hr/metadata/foreign/md/hr_md.c

@@ -59 +59 @@
 static errno_t meta_md_get_block(service_id_t, void **);
 /* static errno_t meta_md_write_block(service_id_t, const void *); */
-static bool meta_md_has_valid_magic(const void *);
 
 static errno_t meta_md_probe(service_id_t, void **);
@@ -115 +114 @@
                 goto error;
 
-        if (!meta_md_has_valid_magic(metadata_struct)) {
-                rc = ENOFS;
-                goto error;
-        }
-
         *rmd = metadata_struct;
         return EOK;
@@ -125 +119 @@
 error:
         free(metadata_struct);
-        return ENOFS;
+        return rc;
 }
 
@@ -610 +604 @@
 #endif
 
-static bool meta_md_has_valid_magic(const void *md_v)
-{
-        HR_DEBUG("%s()", __func__);
-
-        const struct mdp_superblock_1 *md = md_v;
-
-        if (md->magic != MD_MAGIC)
-                return false;
-
-        return true;
-}
-
 /** @}
  */