Changes in uspace/drv/bus/usb/usbmast/main.c [2aceec5:f7a55f9] in mainline

File:

• uspace/drv/bus/usb/usbmast/main.c (modified) (7 diffs)

uspace/drv/bus/usb/usbmast/main.c

@@ -1 +1 @@
 /*
  * Copyright (c) 2011 Vojtech Horky
- * Copyright (c) 2011 Jiri Svoboda
  * All rights reserved.
  *
@@ -35 +34 @@
  * Main routines of USB mass storage driver.
  */
-#include <as.h>
-#include <async.h>
-#include <ipc/bd.h>
-#include <macros.h>
 #include <usb/dev/driver.h>
 #include <usb/debug.h>
@@ -45 +40 @@
 #include <errno.h>
 #include <str_error.h>
-#include "cmdw.h"
-#include "bo_trans.h"
+#include "cmds.h"
+#include "mast.h"
 #include "scsi_ms.h"
-#include "usbmast.h"
 
 #define NAME "usbmast"
@@ -78 +72 @@
 };
 
-static int usbmast_fun_create(usbmast_dev_t *mdev, unsigned lun);
-static void usbmast_bd_connection(ipc_callid_t iid, ipc_call_t *icall,
-    void *arg);
-
 /** Callback when new device is attached and recognized as a mass storage.
  *
@@ -90 +80 @@
 {
         int rc;
-        usbmast_dev_t *mdev = NULL;
-        unsigned i;
+        const char *fun_name = "ctl";
 
-        /* Allocate softstate */
-        mdev = calloc(1, sizeof(usbmast_dev_t));
-        if (mdev == NULL) {
-                usb_log_error("Failed allocating softstate.\n");
-                rc = ENOMEM;
-                goto error;
+        ddf_fun_t *ctl_fun = ddf_fun_create(dev->ddf_dev, fun_exposed,
+            fun_name);
+        if (ctl_fun == NULL) {
+                usb_log_error("Failed to create control function.\n");
+                return ENOMEM;
+        }
+        rc = ddf_fun_bind(ctl_fun);
+        if (rc != EOK) {
+                usb_log_error("Failed to bind control function: %s.\n",
+                    str_error(rc));
+                return rc;
         }
 
-        mdev->ddf_dev = dev->ddf_dev;
-        mdev->usb_dev = dev;
-
-        usb_log_info("Initializing mass storage `%s'.\n",
+        usb_log_info("Pretending to control mass storage `%s'.\n",
             dev->ddf_dev->name);
         usb_log_debug(" Bulk in endpoint: %d [%zuB].\n",
@@ -114 +105 @@
 
         usb_log_debug("Get LUN count...\n");
-        mdev->luns = usb_masstor_get_lun_count(mdev);
-
-        for (i = 0; i < mdev->luns; i++) {
-                rc = usbmast_fun_create(mdev, i);
-                if (rc != EOK)
-                        goto error;
-        }
-
-        return EOK;
-error:
-        /* XXX Destroy functions */
-        if (mdev != NULL)
-                free(mdev);
-        return rc;
-}
-
-/** Create mass storage function.
- *
- * Called once for each LUN.
- *
- * @param mdev          Mass storage device
- * @param lun           LUN
- * @return              EOK on success or negative error code.
- */
-static int usbmast_fun_create(usbmast_dev_t *mdev, unsigned lun)
-{
-        int rc;
-        char *fun_name = NULL;
-        ddf_fun_t *fun = NULL;
-        usbmast_fun_t *mfun = NULL;
-
-        /* Allocate softstate */
-        mfun = calloc(1, sizeof(usbmast_fun_t));
-        if (mfun == NULL) {
-                usb_log_error("Failed allocating softstate.\n");
-                rc = ENOMEM;
-                goto error;
-        }
-
-        mfun->mdev = mdev;
-        mfun->lun = lun;
-
-        if (asprintf(&fun_name, "l%u", lun) < 0) {
-                usb_log_error("Out of memory.\n");
-                rc = ENOMEM;
-                goto error;
-        }
-
-        fun = ddf_fun_create(mdev->ddf_dev, fun_exposed, fun_name);
-        if (fun == NULL) {
-                usb_log_error("Failed to create DDF function %s.\n", fun_name);
-                rc = ENOMEM;
-                goto error;
-        }
-
-        free(fun_name);
-        fun_name = NULL;
-
-        /* Set up a connection handler. */
-        fun->conn_handler = usbmast_bd_connection;
-        fun->driver_data = mfun;
+        size_t lun_count = usb_masstor_get_lun_count(dev);
 
         usb_log_debug("Inquire...\n");
         usbmast_inquiry_data_t inquiry;
-        rc = usbmast_inquiry(mfun, &inquiry);
+        rc = usbmast_inquiry(dev, &inquiry);
         if (rc != EOK) {
                 usb_log_warning("Failed to inquire device `%s': %s.\n",
-                    mdev->ddf_dev->name, str_error(rc));
-                rc = EIO;
-                goto error;
+                    dev->ddf_dev->name, str_error(rc));
+                return EOK;
         }
 
-        usb_log_info("Mass storage `%s' LUN %u: " \
-            "%s by %s rev. %s is %s (%s).\n",
-            mdev->ddf_dev->name,
-            lun,
+        usb_log_info("Mass storage `%s': " \
+            "%s by %s rev. %s is %s (%s), %zu LUN(s).\n",
+            dev->ddf_dev->name,
             inquiry.product,
             inquiry.vendor,
             inquiry.revision,
             usbmast_scsi_dev_type_str(inquiry.device_type),
-            inquiry.removable ? "removable" : "non-removable");
+            inquiry.removable ? "removable" : "non-removable",
+            lun_count);
 
         uint32_t nblocks, block_size;
 
-        rc = usbmast_read_capacity(mfun, &nblocks, &block_size);
+        rc = usbmast_read_capacity(dev, &nblocks, &block_size);
         if (rc != EOK) {
                 usb_log_warning("Failed to read capacity, device `%s': %s.\n",
-                    mdev->ddf_dev->name, str_error(rc));
-                rc = EIO;
-                goto error;
+                    dev->ddf_dev->name, str_error(rc));
+                return EOK;
         }
 
@@ -209 +138 @@
             "block_size=%" PRIu32 "\n", nblocks, block_size);
 
-        mfun->nblocks = nblocks;
-        mfun->block_size = block_size;
+        usb_log_info("Doing test read of block 0.\n");
+        static uint8_t bdata[512];
 
-        rc = ddf_fun_bind(fun);
+        rc = usbmast_read(dev, 0, 1, 512, &bdata);
         if (rc != EOK) {
-                usb_log_error("Failed to bind DDF function %s: %s.\n",
-                    fun_name, str_error(rc));
-                goto error;
+                usb_log_warning("Failed to read block 0, device `%s': %s.\n",
+                    dev->ddf_dev->name, str_error(rc));
+                return EOK;
+        }
+
+        usb_log_info("Requesting sense data.\n");
+        static scsi_sense_data_t sdata;
+
+        rc = usbmast_request_sense(dev, &sdata, sizeof(sdata));
+        if (rc != EOK) {
+                usb_log_warning("Failed to get sense data, device `%s': %s.\n",
+                    dev->ddf_dev->name, str_error(rc));
+                return EOK;
         }
 
         return EOK;
-
-        /* Error cleanup */
-error:
-        if (fun != NULL)
-                ddf_fun_destroy(fun);
-        if (fun_name != NULL)
-                free(fun_name);
-        if (mfun != NULL)
-                free(mfun);
-        return rc;
-}
-
-/** Blockdev client connection handler. */
-static void usbmast_bd_connection(ipc_callid_t iid, ipc_call_t *icall,
-    void *arg)
-{
-        usbmast_fun_t *mfun;
-        void *comm_buf = NULL;
-        size_t comm_size;
-        ipc_callid_t callid;
-        ipc_call_t call;
-        unsigned int flags;
-        sysarg_t method;
-        uint64_t ba;
-        size_t cnt;
-        int retval;
-
-        async_answer_0(iid, EOK);
-
-        if (!async_share_out_receive(&callid, &comm_size, &flags)) {
-                async_answer_0(callid, EHANGUP);
-                return;
-        }
-
-        comm_buf = as_get_mappable_page(comm_size);
-        if (comm_buf == NULL) {
-                async_answer_0(callid, EHANGUP);
-                return;
-        }
-
-        (void) async_share_out_finalize(callid, comm_buf);
-
-        mfun = (usbmast_fun_t *) ((ddf_fun_t *)arg)->driver_data;
-
-        while (true) {
-                callid = async_get_call(&call);
-                method = IPC_GET_IMETHOD(call);
-
-                if (!method) {
-                        /* The other side hung up. */
-                        async_answer_0(callid, EOK);
-                        return;
-                }
-
-                switch (method) {
-                case BD_GET_BLOCK_SIZE:
-                        async_answer_1(callid, EOK, mfun->block_size);
-                        break;
-                case BD_GET_NUM_BLOCKS:
-                        async_answer_2(callid, EOK, LOWER32(mfun->nblocks),
-                            UPPER32(mfun->nblocks));
-                        break;
-                case BD_READ_BLOCKS:
-                        ba = MERGE_LOUP32(IPC_GET_ARG1(call), IPC_GET_ARG2(call));
-                        cnt = IPC_GET_ARG3(call);
-                        retval = usbmast_read(mfun, ba, cnt, comm_buf);
-                        async_answer_0(callid, retval);
-                        break;
-                case BD_WRITE_BLOCKS:
-                        ba = MERGE_LOUP32(IPC_GET_ARG1(call), IPC_GET_ARG2(call));
-                        cnt = IPC_GET_ARG3(call);
-                        retval = usbmast_write(mfun, ba, cnt, comm_buf);
-                        async_answer_0(callid, retval);
-                        break;
-                default:
-                        async_answer_0(callid, EINVAL);
-                }
-        }
 }