Changes in uspace/srv/bd/file_bd/file_bd.c [1e4cada:ed903174] in mainline

File:

• uspace/srv/bd/file_bd/file_bd.c (modified) (7 diffs)

uspace/srv/bd/file_bd/file_bd.c

@@ -48 +48 @@
 #include <devmap.h>
 #include <sys/types.h>
+#include <sys/typefmt.h>
 #include <errno.h>
 #include <bool.h>
@@ -56 +57 @@
 
 static const size_t block_size = 512;
+static aoff64_t num_blocks;
 static FILE *img;
 
@@ -99 +101 @@
 {
         int rc;
+        long img_size;
 
         rc = devmap_driver_register(NAME, file_bd_connection);
@@ -109 +112 @@
         if (img == NULL)
                 return EINVAL;
+
+        if (fseek(img, 0, SEEK_END) != 0) {
+                fclose(img);
+                return EIO;
+        }
+
+        img_size = ftell(img);
+        if (img_size < 0) {
+                fclose(img);
+                return EIO;
+        }
+
+        num_blocks = img_size / block_size;
 
         fibril_mutex_initialize(&dev_lock);
@@ -174 +190 @@
                         ipc_answer_1(callid, EOK, block_size);
                         continue;
+                case BD_GET_NUM_BLOCKS:
+                        ipc_answer_2(callid, EOK, LOWER32(num_blocks),
+                            UPPER32(num_blocks));
+                        continue;
                 default:
                         retval = EINVAL;
@@ -186 +206 @@
 {
         size_t n_rd;
+        int rc;
+
+        /* Check whether access is within device address bounds. */
+        if (ba + cnt > num_blocks) {
+                printf(NAME ": Accessed blocks %" PRIuOFF64 "-%" PRIuOFF64 ", while "
+                    "max block number is %" PRIuOFF64 ".\n", ba, ba + cnt - 1,
+                    num_blocks - 1);
+                return ELIMIT;
+        }
 
         fibril_mutex_lock(&dev_lock);
 
-        fseek(img, ba * block_size, SEEK_SET);
+        clearerr(img);
+        rc = fseek(img, ba * block_size, SEEK_SET);
+        if (rc < 0) {
+                fibril_mutex_unlock(&dev_lock);
+                return EIO;
+        }
+
         n_rd = fread(buf, block_size, cnt, img);
 
@@ -209 +244 @@
 {
         size_t n_wr;
+        int rc;
+
+        /* Check whether access is within device address bounds. */
+        if (ba + cnt > num_blocks) {
+                printf(NAME ": Accessed blocks %" PRIuOFF64 "-%" PRIuOFF64 ", while "
+                    "max block number is %" PRIuOFF64 ".\n", ba, ba + cnt - 1,
+                    num_blocks - 1);
+                return ELIMIT;
+        }
 
         fibril_mutex_lock(&dev_lock);
 
-        fseek(img, ba * block_size, SEEK_SET);
-        n_wr = fread(buf, block_size, cnt, img);
+        clearerr(img);
+        rc = fseek(img, ba * block_size, SEEK_SET);
+        if (rc < 0) {
+                fibril_mutex_unlock(&dev_lock);
+                return EIO;
+        }
+
+        n_wr = fwrite(buf, block_size, cnt, img);
 
         if (ferror(img) || n_wr < cnt) {
                 fibril_mutex_unlock(&dev_lock);
                 return EIO;     /* Write error */
+        }
+
+        if (fflush(img) != 0) {
+                fibril_mutex_unlock(&dev_lock);
+                return EIO;
         }