Changes in uspace/lib/posix/sys/stat.c [9b1503e:ec18957a] in mainline

File:

• uspace/lib/posix/sys/stat.c (modified) (4 diffs)

uspace/lib/posix/sys/stat.c

@@ -36 +36 @@
 #define LIBPOSIX_INTERNAL
 
+#include "../internal/common.h"
 #include "stat.h"
-#include "../internal/common.h"
-#include <mem.h>
+
+#include "../errno.h"
+#include "../libc/mem.h"
 
 /**
- * Convert HelenOS stat struct into POSIX stat struct (if possible)
+ * Convert HelenOS stat struct into POSIX stat struct (if possible).
  *
- * @param dest
- * @param src
+ * @param dest POSIX stat struct.
+ * @param src HelenOS stat struct.
  */
 static void stat_to_posix(struct posix_stat *dest, struct stat *src)
@@ -66 +68 @@
 
 /**
+ * Retrieve file status for file associated with file descriptor.
  *
- * @param fd
- * @param st
- * @return
+ * @param fd File descriptor of the opened file.
+ * @param st Status structure to be filled with information.
+ * @return Zero on success, -1 otherwise.
  */
 int posix_fstat(int fd, struct posix_stat *st)
 {
         struct stat hst;
-        if (fstat(fd, &hst) == -1) {
-                // TODO: propagate a POSIX compatible errno
+        int rc = fstat(fd, &hst);
+        if (rc < 0) {
+                /* fstat() returns negative error code instead of using errno.
+                 */
+                errno = -rc;
                 return -1;
         }
@@ -83 +89 @@
 
 /**
+ * Retrieve file status for symbolic link.
  * 
- * @param path
- * @param st
- * @return
+ * @param path Path to the symbolic link.
+ * @param st Status structure to be filled with information.
+ * @return Zero on success, -1 otherwise.
  */
-int posix_lstat(const char *restrict path, struct posix_stat *restrict st)
+int posix_lstat(const char *path, struct posix_stat *st)
 {
-        // TODO
-        not_implemented();
+        /* There are currently no symbolic links in HelenOS. */
+        return posix_stat(path, st);
 }
 
 /**
+ * Retrieve file status for regular file (or symbolic link target).
  *
- * @param path
- * @param st
- * @return
+ * @param path Path to the file/link.
+ * @param st Status structure to be filled with information.
+ * @return Zero on success, -1 otherwise.
  */
 int posix_stat(const char *path, struct posix_stat *st)
 {
         struct stat hst;
-        if (stat(path, &hst) == -1) {
-                // TODO: propagate a POSIX compatible errno
+        int rc = stat(path, &hst);
+        if (rc < 0) {
+                /* stat() returns negative error code instead of using errno.
+                 */
+                errno = -rc;
                 return -1;
         }
@@ -112 +123 @@
 
 /**
+ * Change permission bits for the file if possible.
  * 
- * @param path
- * @param mode
- * @return
+ * @param path Path to the file.
+ * @param mode Permission bits to be set.
+ * @return Zero on success, -1 otherwise.
  */
 int posix_chmod(const char *path, mode_t mode)
 {
-        // TODO
-        not_implemented();
+        /* HelenOS doesn't support permissions, return success. */
+        return 0;
 }
 
 /**
+ * Set the file mode creation mask of the process.
  * 
- * @param mask
- * @return
+ * @param mask Set permission bits are cleared in the related creation
+ *     functions. Non-permission bits are ignored.
+ * @return Previous file mode creation mask.
  */
 mode_t posix_umask(mode_t mask)
 {
-        // TODO
-        not_implemented();
+        /* HelenOS doesn't support permissions, return empty mask. */
+        return 0;
 }