Changes in uspace/drv/uhci-hcd/transfer_list.c [4fd3faf:da88eb82] in mainline

File:

• uspace/drv/uhci-hcd/transfer_list.c (modified) (3 diffs)

uspace/drv/uhci-hcd/transfer_list.c

@@ -132 +132 @@
 }
 /*----------------------------------------------------------------------------*/
-/** Create list for finished batches.
- *
- * @param[in] instance List to use.
- * @param[in] done list to fill
+/** Check list for finished batches.
+ *
+ * @param[in] instance List to use.
+ * @return Error code
+ *
+ * Creates a local list of finished batches and calls next_step on each and
+ * every one. This is safer because next_step may theoretically access
+ * this transfer list leading to the deadlock if its done inline.
  */
 void transfer_list_remove_finished(transfer_list_t *instance, link_t *done)
@@ -157 +161 @@
         }
         fibril_mutex_unlock(&instance->guard);
+
 }
 /*----------------------------------------------------------------------------*/
@@ -171 +176 @@
                     list_get_instance(current, usb_transfer_batch_t, link);
                 transfer_list_remove_batch(instance, batch);
-                usb_transfer_batch_finish_error(batch, EIO);
+                usb_transfer_batch_finish(batch, EIO);
         }
         fibril_mutex_unlock(&instance->guard);