Changes in uspace/lib/usb/src/pipepriv.c [2c2cbcf:d48fcc0] in mainline

File:

• uspace/lib/usb/src/pipepriv.c (modified) (3 diffs)

uspace/lib/usb/src/pipepriv.c

@@ -77 +77 @@
  *
  * @param pipe The USB pipe.
- * @param hide_failure Whether to hide failure when adding reference
- *      (use soft refcount).
  * @return Error code.
  * @retval EOK Currently always.
  */
-int pipe_add_ref(usb_pipe_t *pipe, bool hide_failure)
+int pipe_add_ref(usb_pipe_t *pipe)
 {
+another_try:
         pipe_acquire(pipe);
 
@@ -90 +89 @@
                 int phone = devman_device_connect(pipe->wire->hc_handle, 0);
                 if (phone < 0) {
-                        if (hide_failure) {
-                                pipe->refcount_soft++;
-                                phone = EOK;
-                        }
+                        // TODO: treat some error as non-recoverable
+                        // and return error from here
                         pipe_release(pipe);
-                        return phone;
+                        goto another_try;
                 }
                 /*
@@ -117 +114 @@
 {
         pipe_acquire(pipe);
-        if (pipe->refcount_soft > 0) {
-                pipe->refcount_soft--;
-                pipe_release(pipe);
-                return;
-        }
         assert(pipe->refcount > 0);
         pipe->refcount--;