Changeset c92e30f in mainline

Timestamp:

2012-08-14T20:06:27Z (12 years ago)

Author:

Martin Sucha <sucha14@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a987832

Parents:

4c73361

Message:

ns8250: No need to yield every time we read from the serial device

Location:

uspace/drv/char/ns8250

Files:

• cyclic_buffer.h (modified) (1 diff)
• ns8250.c (modified) (3 diffs)

uspace/drv/char/ns8250/cyclic_buffer.h

@@ -36 +36 @@
 #define CYCLIC_BUFFER_H_
 
-#define BUF_LEN 256
+#define BUF_LEN 4096
 
 typedef struct cyclic_buffer {

uspace/drv/char/ns8250/ns8250.c

@@ -745 +745 @@
         bool cont = true;
         
+        fibril_mutex_lock(&ns->mutex);
         while (cont) {
-                fibril_mutex_lock(&ns->mutex);
-                
                 cont = ns8250_received(regs);
                 if (cont) {
@@ -757 +756 @@
                                         ddf_msg(LVL_WARN, "Buffer overflow on "
                                             "%s.", ns->dev->name);
+                                        break;
                                 } else {
                                         ddf_msg(LVL_DEBUG2, "Character %c saved "
@@ -766 +766 @@
                         }
                 }
-                
-                fibril_mutex_unlock(&ns->mutex);
-                fibril_yield();
-        }
+        }
+        fibril_mutex_unlock(&ns->mutex);
+        fibril_yield();
 }