Changes in uspace/lib/drv/generic/driver.c [79ae36dd:b72efe8] in mainline

File:

• uspace/lib/drv/generic/driver.c (modified) (12 diffs)

uspace/lib/drv/generic/driver.c

@@ -139 +139 @@
 find_interrupt_context_by_id(interrupt_context_list_t *list, int id)
 {
+        interrupt_context_t *ctx;
+        
         fibril_mutex_lock(&list->mutex);
         
-        link_t *link = list->contexts.next;
-        interrupt_context_t *ctx;
-        
-        while (link != &list->contexts) {
+        list_foreach(list->contexts, link) {
                 ctx = list_get_instance(link, interrupt_context_t, link);
                 if (ctx->id == id) {
@@ -150 +149 @@
                         return ctx;
                 }
-                link = link->next;
         }
         
@@ -160 +158 @@
 find_interrupt_context(interrupt_context_list_t *list, ddf_dev_t *dev, int irq)
 {
+        interrupt_context_t *ctx;
+        
         fibril_mutex_lock(&list->mutex);
         
-        link_t *link = list->contexts.next;
-        interrupt_context_t *ctx;
-        
-        while (link != &list->contexts) {
+        list_foreach(list->contexts, link) {
                 ctx = list_get_instance(link, interrupt_context_t, link);
                 if (ctx->irq == irq && ctx->dev == dev) {
@@ -171 +168 @@
                         return ctx;
                 }
-                link = link->next;
         }
         
@@ -231 +227 @@
 }
 
-static ddf_fun_t *driver_get_function(link_t *functions, devman_handle_t handle)
+static ddf_fun_t *driver_get_function(list_t *functions, devman_handle_t handle)
 {
         ddf_fun_t *fun = NULL;
         
         fibril_mutex_lock(&functions_mutex);
-        link_t *link = functions->next;
-        
-        while (link != functions) {
+        
+        list_foreach(*functions, link) {
                 fun = list_get_instance(link, ddf_fun_t, link);
                 if (fun->handle == handle) {
@@ -244 +239 @@
                         return fun;
                 }
-                
-                link = link->next;
         }
         
@@ -361 +354 @@
                         if (default_handler != NULL) {
                                 (*default_handler)(fun, callid, &call);
-                                break;
+                                continue;
                         }
                         
@@ -372 +365 @@
                             driver->name, iface_idx);
                         async_answer_0(callid, ENOTSUP);
-                        break;
+                        continue;
                 }
                 
@@ -384 +377 @@
                             "with id %d.\n", handle, iface_idx);
                         async_answer_0(callid, ENOTSUP);
-                        break;
+                        continue;
                 }
                 
@@ -403 +396 @@
                             "invalid interface method.", driver->name);
                         async_answer_0(callid, ENOTSUP);
-                        break;
+                        continue;
                 }
                 
@@ -413 +406 @@
                  */
                 (*iface_method_ptr)(fun, ops, callid, &call);
-                break;
         }
 }
@@ -428 +420 @@
 
 /** Function for handling connections to device driver. */
-static void driver_connection(ipc_callid_t iid, ipc_call_t *icall)
+static void driver_connection(ipc_callid_t iid, ipc_call_t *icall, void *arg)
 {
         /* Select interface */