Changes in uspace/app/trace/trace.c [9af1c61:a53ed3a] in mainline

File:

• uspace/app/trace/trace.c (modified) (28 diffs)

uspace/app/trace/trace.c

@@ -63 +63 @@
 #include "syscalls.h"
 #include "ipcp.h"
-#include "errors.h"
 #include "trace.h"
 
@@ -94 +93 @@
 display_mask_t display_mask;
 
-static int program_run_fibril(void *arg);
-static int cev_fibril(void *arg);
+static errno_t program_run_fibril(void *arg);
+static errno_t cev_fibril(void *arg);
 
 static void program_run(void)
@@ -123 +122 @@
 }
 
-static int program_run_fibril(void *arg)
-{
-        int rc;
+static errno_t program_run_fibril(void *arg)
+{
+        errno_t rc;
 
         /*
@@ -132 +131 @@
          */
         rc = loader_run(task_ldr);
-        if (rc != 0) {
+        if (rc != EOK) {
                 printf("Error running program\n");
                 exit(1);
@@ -144 +143 @@
 
 
-static int connect_task(task_id_t task_id)
+static errno_t connect_task(task_id_t task_id)
 {
         async_sess_t *ksess = async_connect_kbox(task_id);
@@ -162 +161 @@
         }
         
-        int rc = udebug_begin(ksess);
-        if (rc < 0) {
-                printf("udebug_begin() -> %d\n", rc);
+        errno_t rc = udebug_begin(ksess);
+        if (rc != EOK) {
+                printf("udebug_begin() -> %s\n", str_error_name(rc));
                 return rc;
         }
         
         rc = udebug_set_evmask(ksess, UDEBUG_EM_ALL);
-        if (rc < 0) {
-                printf("udebug_set_evmask(0x%x) -> %d\n ", UDEBUG_EM_ALL, rc);
+        if (rc != EOK) {
+                printf("udebug_set_evmask(0x%x) -> %s\n ", UDEBUG_EM_ALL, str_error_name(rc));
                 return rc;
         }
@@ -178 +177 @@
 }
 
-static int get_thread_list(void)
-{
-        int rc;
+static errno_t get_thread_list(void)
+{
+        errno_t rc;
         size_t tb_copied;
         size_t tb_needed;
@@ -187 +186 @@
         rc = udebug_thread_read(sess, thread_hash_buf,
                 THBUF_SIZE*sizeof(unsigned), &tb_copied, &tb_needed);
-        if (rc < 0) {
-                printf("udebug_thread_read() -> %d\n", rc);
+        if (rc != EOK) {
+                printf("udebug_thread_read() -> %s\n", str_error_name(rc));
                 return rc;
         }
@@ -226 +225 @@
                 if (sval >= -15 && sval <= 0) {
                         printf("%ld %s (%s)", sval,
-                            err_desc[-sval].name,
-                            err_desc[-sval].desc);
+                            str_error_name((errno_t) sval),
+                            str_error((errno_t) sval));
                 } else {
                         printf("%ld", sval);
@@ -235 +234 @@
                 if (sval >= -15 && sval < 0) {
                         printf("%ld %s (%s)", sval,
-                            err_desc[-sval].name,
-                            err_desc[-sval].desc);
+                            str_error_name((errno_t) sval),
+                            str_error((errno_t) sval));
                 } else {
                         printf("%ld", sval);
@@ -280 +279 @@
 }
 
-static void sc_ipc_call_async_fast(sysarg_t *sc_args, sysarg_t sc_rc)
+static void sc_ipc_call_async_fast(sysarg_t *sc_args, errno_t sc_rc)
 {
         ipc_call_t call;
         sysarg_t phoneid;
         
-        if (sc_rc != (sysarg_t) EOK)
+        if (sc_rc != EOK)
                 return;
 
@@ -297 +296 @@
         IPC_SET_ARG5(call, 0);
 
-        ipcp_call_out(phoneid, &call, sc_rc);
-}
-
-static void sc_ipc_call_async_slow(sysarg_t *sc_args, sysarg_t sc_rc)
+        ipcp_call_out(phoneid, &call, 0);
+}
+
+static void sc_ipc_call_async_slow(sysarg_t *sc_args, errno_t sc_rc)
 {
         ipc_call_t call;
-        int rc;
-
-        if (sc_rc != (sysarg_t) EOK)
+        errno_t rc;
+
+        if (sc_rc != EOK)
                 return;
 
@@ -311 +310 @@
         rc = udebug_mem_read(sess, &call.args, sc_args[1], sizeof(call.args));
 
-        if (rc >= 0) {
-                ipcp_call_out(sc_args[0], &call, sc_rc);
+        if (rc == EOK) {
+                ipcp_call_out(sc_args[0], &call, 0);
         }
 }
@@ -319 +318 @@
 {
         ipc_call_t call;
-        int rc;
+        errno_t rc;
 
         if (sc_rc == 0) return;
@@ -326 +325 @@
         rc = udebug_mem_read(sess, &call, sc_args[0], sizeof(call));
         
-        if (rc >= 0)
+        if (rc == EOK)
                 ipcp_call_in(&call, sc_rc);
 }
@@ -334 +333 @@
 {
         sysarg_t sc_args[6];
-        int rc;
+        errno_t rc;
 
         /* Read syscall arguments */
         rc = udebug_args_read(sess, thread_hash, sc_args);
 
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("error\n");
                 return;
@@ -362 +361 @@
         sysarg_t sc_args[6];
         int rv_type;
-        int rc;
+        errno_t rc;
 
         /* Read syscall arguments */
@@ -369 +368 @@
 //      printf("[%d] ", thread_id);
 
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("error\n");
                 return;
@@ -385 +384 @@
         switch (sc_id) {
         case SYS_IPC_CALL_ASYNC_FAST:
-                sc_ipc_call_async_fast(sc_args, sc_rc);
+                sc_ipc_call_async_fast(sc_args, (errno_t) sc_rc);
                 break;
         case SYS_IPC_CALL_ASYNC_SLOW:
-                sc_ipc_call_async_slow(sc_args, sc_rc);
+                sc_ipc_call_async_slow(sc_args, (errno_t) sc_rc);
                 break;
         case SYS_IPC_WAIT:
@@ -404 +403 @@
 }
 
-static int trace_loop(void *thread_hash_arg)
-{
-        int rc;
+static errno_t trace_loop(void *thread_hash_arg)
+{
+        errno_t rc;
         unsigned ev_type;
         uintptr_t thread_hash;
@@ -446 +445 @@
                 }
 
-                if (rc >= 0) {
+                if (rc == EOK) {
                         switch (ev_type) {
                         case UDEBUG_EVENT_SYSCALL_B:
@@ -499 +498 @@
 {
         loader_t *ldr;
-        int rc;
+        errno_t rc;
 
         /* Spawn a program loader */
@@ -567 +566 @@
 }
 
-static int cev_fibril(void *arg)
+static errno_t cev_fibril(void *arg)
 {
         cons_event_t event;
@@ -582 +581 @@
                 
                 if (!console_get_event(console, &event))
-                        return -1;
+                        return EINVAL;
                 
                 if (event.type == CEV_KEY) {
@@ -599 +598 @@
         bool done;
         int i;
-        int rc;
+        errno_t rc;
 
         ipcp_init();
 
         rc = get_thread_list();
-        if (rc < 0) {
-                printf("Failed to get thread list (error %d)\n", rc);
+        if (rc != EOK) {
+                printf("Failed to get thread list (%s)\n", str_error(rc));
                 return;
         }
@@ -644 +643 @@
                         rc = udebug_stop(sess, thash);
                         if (rc != EOK)
-                                printf("Error: stop -> %d\n", rc);
+                                printf("Error: stop -> %s\n", str_error_name(rc));
                         break;
                 case KC_R:
@@ -845 +844 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
         task_exit_t texit;
         int retval;
@@ -860 +859 @@
 
         rc = connect_task(task_id);
-        if (rc < 0) {
+        if (rc != EOK) {
                 printf("Failed connecting to task %" PRIu64 ".\n", task_id);
                 return 1;