Changeset 93ad49a8 in mainline

Timestamp:

2011-08-20T15:03:05Z (13 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

422722e

Parents:

0f4532e

Message:

Make the hack more generic to work around problems with callback
sessions as well.

Location:

uspace/lib/c

Files:

• generic/async.c (modified) (1 diff)
• generic/ns.c (modified) (1 diff)
• include/async.h (modified) (1 diff)

uspace/lib/c/generic/async.c

@@ -1658 +1658 @@
 }
 
-/** Shift arguments for new connections left by one.
+/** Set arguments for new connections.
  *
  * FIXME This is an ugly hack to work around the problem that parallel
  * exchanges are implemented using parallel connections. When we create
- * such a session via a naming server, the naming server shifts the
- * arguments for the initial connection, but not for the latter connections.
+ * a callback session, the framework does not know arguments for the new
+ * connections.
  *
  * The proper solution seems to be to implement parallel exchanges using
  * tagging.
  */
-void async_sess_args_shift(async_sess_t *sess)
-{
-        sess->arg1 = sess->arg2;
-        sess->arg2 = sess->arg3;
-        sess->arg3 = 0;
+void async_sess_args_set(async_sess_t *sess, sysarg_t arg1, sysarg_t arg2,
+    sysarg_t arg3)
+{
+        sess->arg1 = arg1;
+        sess->arg2 = arg2;
+        sess->arg3 = arg3;
 }
 

uspace/lib/c/generic/ns.c

@@ -61 +61 @@
          * first argument for non-initial connections.
          */
-        async_sess_args_shift(sess);
+        async_sess_args_set(sess, arg2, arg3, 0);
         
         return sess;

uspace/lib/c/include/async.h

@@ -333 +333 @@
 extern void async_poke(void);
 
-void async_sess_args_shift(async_sess_t *sess);
-
 extern async_exch_t *async_exchange_begin(async_sess_t *);
 extern void async_exchange_end(async_exch_t *);
+
+/*
+ * FIXME These functions just work around problems with parallel exchange
+ * management. Proper solution needs to be implemented.
+ */
+void async_sess_args_set(async_sess_t *sess, sysarg_t, sysarg_t, sysarg_t);
 
 /*