Changes in / [3dfdcb7:8971926] in mainline


Ignore:
Location:
uspace/drv
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/ohci/root_hub.c

    r3dfdcb7 r8971926  
    5757        .device_version = 0,
    5858        .length = sizeof (usb_standard_device_descriptor_t),
    59         /// \TODO this value is guessed
    6059        .max_packet_size = 8,
    6160        .vendor_id = 0x16db,
     
    468467
    469468        usb_hub_bm_request_type_t request_type = request_packet->request_type;
    470         if (buffer_size < 4/*request_packet->length*/) {///\TODO
     469        if (buffer_size < 4) {
    471470                usb_log_warning("requested more data than buffer size\n");
    472471                return EINVAL;
     
    678677            (instance->registers->rh_port_status[port - 1] | (1 << feature))
    679678            & (~port_clear_feature_valid_mask);
    680         /// \TODO any error?
    681 
    682679        return EOK;
    683680}
     
    707704            & (~port_clear_feature_valid_mask))
    708705            | (1 << feature);
    709         /// \TODO any error?
    710706
    711707        return EOK;
  • uspace/drv/usbhub/main.c

    r3dfdcb7 r8971926  
    8787
    8888        usb_log_enable(USB_LOG_LEVEL_DEFAULT, NAME);
    89        
     89
    9090        return usb_driver_main(&usb_hub_driver);
    9191}
  • uspace/drv/usbhub/usbhub.c

    r3dfdcb7 r8971926  
    249249        usb_log_debug("setting port count to %d\n", descriptor->ports_count);
    250250        hub_info->port_count = descriptor->ports_count;
    251         /// \TODO this is not semantically correct
    252251        bool is_power_switched =
    253252            ((descriptor->hub_characteristics & 1) == 0);
Note: See TracChangeset for help on using the changeset viewer.