Changeset 7364e2d1 in mainline

Timestamp:

2024-01-21T15:24:36Z (3 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

33e15a0

Parents:

41bfc64

Message:

Don't try to determine internal thread state when requesting stack trace

thread_wakeup() is idempotent, it can be called at an arbitrary time and
it will only wake up a thread when it's sleeping, with no chance of any
races. Checking if istate is present from "outside" the thread is just
an unnecessary and a wrong thing to do.

Location:

kernel/generic/src/proc

Files:

• scheduler.c (modified) (1 diff)
• thread.c (modified) (1 diff)

kernel/generic/src/proc/scheduler.c

@@ -345 +345 @@
                         printf("Thread %" PRIu64 " stack trace:\n", THREAD->tid);
                         stack_trace_istate(istate);
+                } else {
+                        printf("Thread %" PRIu64 " interrupt state not available\n", THREAD->tid);
                 }
 

kernel/generic/src/proc/thread.c

@@ -907 +907 @@
          */
 
+        printf("Scheduling thread stack trace.\n");
         irq_spinlock_lock(&thread->lock, true);
-
-        bool sleeping = false;
-        istate_t *istate = thread->udebug.uspace_state;
-        if (istate != NULL) {
-                printf("Scheduling thread stack trace.\n");
-                thread->btrace = true;
-                if (atomic_get_unordered(&thread->state) == Sleeping)
-                        sleeping = true;
-        } else
-                printf("Thread interrupt state not available.\n");
-
+        thread->btrace = true;
         irq_spinlock_unlock(&thread->lock, true);
 
-        if (sleeping)
-                thread_wakeup(thread);
-
+        thread_wakeup(thread);
         thread_put(thread);
 }