Changeset 6df4adc4 in mainline

Timestamp:

2012-12-30T19:56:50Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9e2132a

Parents:

68e1023

Message:

usbmid: Spawn ddf functions sooner.

File:

• uspace/drv/bus/usb/usbmid/explore.c (modified) (4 diffs)

uspace/drv/bus/usb/usbmid/explore.c

@@ -72 +72 @@
  * @param list List where to add the interfaces.
  */
-static void create_interfaces(const uint8_t *config_descriptor,
-    size_t config_descriptor_size, list_t *list)
+static int create_interfaces(const uint8_t *config_descriptor,
+    size_t config_descriptor_size, list_t *list, usb_device_t *usb_dev)
 {
+        assert(config_descriptor);
+        assert(usb_dev);
+
         const usb_dp_parser_data_t data = {
                 .data = config_descriptor,
@@ -107 +110 @@
                         continue;
                 }
+
                 usbmid_interface_t *iface = malloc(sizeof(usbmid_interface_t));
                 if (iface == NULL) {
@@ -119 +123 @@
 
                 list_append(&iface->link, list);
-        }
+
+                usb_log_info("Creating child for interface %d (%s).\n",
+                    interface->interface_number,
+                    usb_str_class(interface->interface_class));
+
+                const int rc = usbmid_spawn_interface_child(usb_dev, iface,
+                    &usb_dev->descriptors.device, interface);
+                if (rc != EOK) {
+                        usb_log_error("Failed to create interface child for "
+                            "%d (%s): %s.\n", interface->interface_number,
+                            usb_str_class(interface->interface_class),
+                            str_error(rc));
+                }
+        }
+        return EOK;
 }
 
@@ -187 +205 @@
         list_initialize(&usb_mid->interface_list);
         create_interfaces(config_descriptor_raw, config_descriptor_size,
-            &usb_mid->interface_list);
-
-        /* Start child function for every interface. */
-        list_foreach(usb_mid->interface_list, link) {
-                usbmid_interface_t *iface = usbmid_interface_from_link(link);
-
-                usb_log_info("Creating child for interface %d.\n",
-                    iface->interface_no);
-
-                rc = usbmid_spawn_interface_child(dev, iface,
-                    &dev->descriptors.device, iface->interface);
-                if (rc != EOK) {
-                        usb_log_error("Failed to create interface child: %s.\n",
-                            str_error(rc));
-                }
-        }
+            &usb_mid->interface_list, dev);
 
         return EOK;