Changes in uspace/drv/pciintel/pci.c [d93aafed:663f41c4] in mainline

File:

• uspace/drv/pciintel/pci.c (modified) (17 diffs)

uspace/drv/pciintel/pci.c

@@ -65 +65 @@
         pci_dev_data_t *dev_data = (pci_dev_data_t *) dev->driver_data;
         
-        if (dev_data == NULL)
+        if (NULL == dev_data)
                 return NULL;
         return &dev_data->hw_resources;
@@ -109 +109 @@
         
         bus_data = (pci_bus_data_t *) malloc(sizeof(pci_bus_data_t));
-        if (bus_data != NULL) {
+        if (NULL != bus_data) {
                 memset(bus_data, 0, sizeof(pci_bus_data_t));
                 fibril_mutex_initialize(&bus_data->conf_mutex);
         }
-
         return bus_data;
 }
@@ -124 +123 @@
 static void pci_conf_read(device_t *dev, int reg, uint8_t *buf, size_t len)
 {
-        assert(dev->parent != NULL);
+        assert(NULL != dev->parent);
         
         pci_dev_data_t *dev_data = (pci_dev_data_t *) dev->driver_data;
@@ -154 +153 @@
 static void pci_conf_write(device_t *dev, int reg, uint8_t *buf, size_t len)
 {
-        assert(dev->parent != NULL);
+        assert(NULL != dev->parent);
         
         pci_dev_data_t *dev_data = (pci_dev_data_t *) dev->driver_data;
@@ -225 +224 @@
         
         match_id = create_match_id();
-        if (match_id != NULL) {
+        if (NULL != match_id) {
                 asprintf(&match_id_str, "pci/ven=%04x&dev=%04x",
                     dev_data->vendor_id, dev_data->device_id);
@@ -231 +230 @@
                 match_id->score = 90;
                 add_match_id(&dev->match_ids, match_id);
-        }
-
+        }       
         /* TODO add more ids (with subsys ids, using class id etc.) */
 }
@@ -244 +242 @@
         size_t count = hw_res_list->count;
         
-        assert(hw_resources != NULL);
+        assert(NULL != hw_resources);
         assert(count < PCI_MAX_HW_RES);
         
@@ -277 +275 @@
         bool io;
         /* 64-bit wide address */
-        bool addrw64;
+        bool w64;
         
         /* Size of the io or memory range specified by the BAR */
@@ -289 +287 @@
         io = (bool) (val & 1);
         if (io) {
-                addrw64 = false;
+                w64 = false;
         } else {
                 switch ((val >> 1) & 3) {
                 case 0:
-                        addrw64 = false;
+                        w64 = false;
                         break;
                 case 2:
-                        addrw64 = true;
+                        w64 = true;
                         break;
                 default:
@@ -314 +312 @@
         range_size = pci_bar_mask_to_size(mask);
         
-        if (addrw64) {
+        if (w64) {
                 range_addr = ((uint64_t)pci_conf_read_32(dev, addr + 4) << 32) |
                     (val & 0xfffffff0);
@@ -321 +319 @@
         }
         
-        if (range_addr != 0) {
+        if (0 != range_addr) {
                 printf(NAME ": device %s : ", dev->name);
                 printf("address = %x", range_addr);
@@ -329 +327 @@
         pci_add_range(dev, range_addr, range_size, io);
         
-        if (addrw64)
+        if (w64)
                 return addr + 8;
         
@@ -356 +354 @@
 {
         uint8_t irq = pci_conf_read_8(dev, PCI_BRIDGE_INT_LINE);
-        if (irq != 0xff)
+        if (0xff != irq)
                 pci_add_interrupt(dev, irq);
 }
@@ -417 +415 @@
                         create_pci_match_ids(dev);
                         
-                        if (child_device_register(dev, parent) != EOK) {
+                        if (EOK != child_device_register(dev, parent)) {
                                 pci_clean_resource_list(dev);
                                 clean_match_ids(&dev->match_ids);
@@ -426 +424 @@
                         
                         if (header_type == PCI_HEADER_TYPE_BRIDGE ||
-                            header_type == PCI_HEADER_TYPE_CARDBUS) {
+                            header_type == PCI_HEADER_TYPE_CARDBUS ) {
                                 child_bus = pci_conf_read_8(dev,
                                     PCI_BRIDGE_SEC_BUS_NUM);
                                 printf(NAME ": device is pci-to-pci bridge, "
                                     "secondary bus number = %d.\n", bus_num);
-                                if (child_bus > bus_num)
+                                if(child_bus > bus_num)
                                         pci_bus_scan(parent, child_bus);
                         }
@@ -455 +453 @@
         
         pci_bus_data_t *bus_data = create_pci_bus_data();
-        if (bus_data == NULL) {
+        if (NULL == bus_data) {
                 printf(NAME ": pci_add_device allocation failed.\n");
                 return ENOMEM;
@@ -515 +513 @@
 }
 
-pci_dev_data_t *create_pci_dev_data(void)
-{
-        pci_dev_data_t *res = (pci_dev_data_t *) malloc(sizeof(pci_dev_data_t));
-        
-        if (res != NULL)
-                memset(res, 0, sizeof(pci_dev_data_t));
-        return res;
-}
-
-void init_pci_dev_data(pci_dev_data_t *dev_data, int bus, int dev, int fn)
-{
-        dev_data->bus = bus;
-        dev_data->dev = dev;
-        dev_data->fn = fn;
-}
-
-void delete_pci_dev_data(pci_dev_data_t *dev_data)
-{
-        if (dev_data != NULL) {
-                clean_hw_resource_list(&dev_data->hw_resources);
-                free(dev_data);
-        }
-}
-
-void create_pci_dev_name(device_t *dev)
-{
-        pci_dev_data_t *dev_data = (pci_dev_data_t *) dev->driver_data;
-        char *name = NULL;
-        
-        asprintf(&name, "%02x:%02x.%01x", dev_data->bus, dev_data->dev,
-            dev_data->fn);
-        dev->name = name;
-}
-
-bool pci_alloc_resource_list(device_t *dev)
-{
-        pci_dev_data_t *dev_data = (pci_dev_data_t *)dev->driver_data;
-        
-        dev_data->hw_resources.resources =
-            (hw_resource_t *) malloc(PCI_MAX_HW_RES * sizeof(hw_resource_t));
-        return dev_data->hw_resources.resources != NULL;
-}
-
-void pci_clean_resource_list(device_t *dev)
-{
-        pci_dev_data_t *dev_data = (pci_dev_data_t *) dev->driver_data;
-        
-        if (dev_data->hw_resources.resources != NULL) {
-                free(dev_data->hw_resources.resources);
-                dev_data->hw_resources.resources = NULL;
-        }
-}
-
-/** Read the base address registers (BARs) of the device and adds the addresses
- * to its hw resource list.
- *
- * @param dev the pci device.
- */
-void pci_read_bars(device_t *dev)
-{
-        /*
-         * Position of the BAR in the PCI configuration address space of the
-         * device.
-         */
-        int addr = PCI_BASE_ADDR_0;
-        
-        while (addr <= PCI_BASE_ADDR_5)
-                addr = pci_read_bar(dev, addr);
-}
-
-size_t pci_bar_mask_to_size(uint32_t mask)
-{
-        return ((mask & 0xfffffff0) ^ 0xffffffff) + 1;
-}
-
 int main(int argc, char *argv[])
 {