Changes in uspace/srv/net/tl/tcp/tcp_module.c [fb04cba8:614d065] in mainline

File:

• uspace/srv/net/tl/tcp/tcp_module.c (modified) (2 diffs)

uspace/srv/net/tl/tcp/tcp_module.c

@@ -28 +28 @@
 
 /** @addtogroup tcp
- * @{
+ *  @{
  */
 
 /** @file
- * TCP standalone module implementation.
- * Contains skeleton module functions mapping.
- * The functions are used by the module skeleton as module specific entry
- * points.
- * @see module.c
+ *  TCP standalone module implementation.
+ *  Contains skeleton module functions mapping.
+ *  The functions are used by the module skeleton as module specific entry points.
+ *  @see module.c
  */
-
-#include "tcp.h"
-#include "tcp_module.h"
 
 #include <async.h>
 #include <stdio.h>
-#include <errno.h>
+#include <err.h>
 #include <ipc/ipc.h>
 #include <ipc/services.h>
@@ -50 +46 @@
 #include <net/ip_protocols.h>
 #include <net/modules.h>
+
 #include <net/packet.h>
 #include <net_interface.h>
-
 #include <ip_interface.h>
 #include <tl_local.h>
 
-/** TCP module global data. */
-extern tcp_globals_t tcp_globals;
+#include "tcp.h"
+#include "tcp_module.h"
 
+/** TCP module global data.
+ */
+extern tcp_globals_t    tcp_globals;
+
+/** Starts the TCP module.
+ *  Initializes the client connection serving function, initializes the module, registers the module service and starts the async manager, processing IPC messages in an infinite loop.
+ *  @param[in] client_connection The client connection processing function. The module skeleton propagates its own one.
+ *  @returns EOK on successful module termination.
+ *  @returns Other error codes as defined for the tcp_initialize() function.
+ *  @returns Other error codes as defined for the REGISTER_ME() macro function.
+ */
 int tl_module_start_standalone(async_client_conn_t client_connection)
 {
-        ipcarg_t phonehash;
-        int rc;
-
+        ERROR_DECLARE;
+        
         async_set_client_connection(client_connection);
         tcp_globals.net_phone = net_connect_module();
-
-        rc = pm_init();
-        if (rc != EOK)
-                return rc;
-
-        rc = tcp_initialize(client_connection);
-        if (rc != EOK)
-                goto out;
-
-        rc = REGISTER_ME(SERVICE_TCP, &phonehash);
-        if (rc != EOK)
-                goto out;
+        ERROR_PROPAGATE(pm_init());
+        
+        ipcarg_t phonehash;
+        if (ERROR_OCCURRED(tcp_initialize(client_connection))
+            || ERROR_OCCURRED(REGISTER_ME(SERVICE_TCP, &phonehash))) {
+                pm_destroy();
+                return ERROR_CODE;
+        }
         
         async_manager();
         
-out:
         pm_destroy();
-        return rc;
+        return EOK;
 }
 
-int tl_module_message_standalone(ipc_callid_t callid, ipc_call_t *call,
-    ipc_call_t *answer, int *answer_count)
-{
+/** Processes the TCP message.
+ *  @param[in] callid The message identifier.
+ *  @param[in] call The message parameters.
+ *  @param[out] answer The message answer parameters.
+ *  @param[out] answer_count The last parameter for the actual answer in the answer parameter.
+ *  @returns EOK on success.
+ *  @returns Other error codes as defined for the tcp_message() function.
+ */
+int tl_module_message_standalone(ipc_callid_t callid, ipc_call_t * call, ipc_call_t * answer, int * answer_count){
         return tcp_message_standalone(callid, call, answer, answer_count);
 }