Changes in uspace/lib/gui/terminal.c [ba733e83:5d94b16c] in mainline

File:

• uspace/lib/gui/terminal.c (modified) (1 diff)

uspace/lib/gui/terminal.c

@@ -196 +196 @@
         uint16_t glyph = fb_font_glyph(field->ch);
         
+        // FIXME: This font drawing routine is shamelessly
+        //        suboptimal. It should be optimized for
+        //        aligned memory transfers, etc.
+        
         for (unsigned int y = 0; y < FONT_SCANLINES; y++) {
-                pixel_t *dst = pixelmap_pixel_at(
-                    surface_pixmap_access(surface), bx, by + y);
-                pixel_t *dst_max = pixelmap_pixel_at(
-                    surface_pixmap_access(surface), bx + FONT_WIDTH - 1, by + y);
-                if (!dst || !dst_max) continue;
-                int count = FONT_WIDTH;
-                while (count-- != 0) {
-                        *dst++ = (fb_font[glyph][y] & (1 << count)) ? fgcolor : bgcolor;
+                for (unsigned int x = 0; x < FONT_WIDTH; x++) {
+                        pixel_t pixel =
+                            (fb_font[glyph][y] & (1 << (7 - x))) ? fgcolor : bgcolor;
+                        surface_put_pixel(surface, bx + x, by + y, pixel);
                 }
         }
-        surface_add_damaged_region(surface, bx, by, FONT_WIDTH, FONT_SCANLINES);
 }