Changes in uspace/drv/bus/usb/ohci/hc.c [0cd8089:57e06ef] in mainline

File:

• uspace/drv/bus/usb/ohci/hc.c (modified) (3 diffs)

uspace/drv/bus/usb/ohci/hc.c

@@ -127 +127 @@
         assert(hub_fun);
 
-        /* Try to get address 1 for root hub. */
-        instance->rh.address = 1;
-        int ret = usb_device_manager_request_address(
-            &instance->generic.dev_manager, &instance->rh.address, false,
-            USB_SPEED_FULL);
-        if (ret != EOK) {
+        const usb_address_t hub_address =
+            usb_device_manager_get_free_address(
+                &instance->generic.dev_manager, USB_SPEED_FULL);
+        if (hub_address <= 0) {
                 usb_log_error("Failed to get OHCI root hub address: %s\n",
-                    str_error(ret));
-                return ret;
-        }
-        usb_device_manager_bind_address(&instance->generic.dev_manager,
-            instance->rh.address, hub_fun->handle);
+                    str_error(hub_address));
+                return hub_address;
+        }
+        instance->rh.address = hub_address;
+        usb_device_manager_bind(
+            &instance->generic.dev_manager, hub_address, hub_fun->handle);
 
 #define CHECK_RET_UNREG_RETURN(ret, message...) \
@@ -144 +143 @@
         usb_log_error(message); \
         usb_endpoint_manager_remove_ep( \
-            &instance->generic.ep_manager, instance->rh.address, 0, \
-            USB_DIRECTION_BOTH, NULL, NULL); \
-        usb_device_manager_release_address( \
-            &instance->generic.dev_manager, instance->rh.address); \
+            &instance->generic.ep_manager, hub_address, 0, USB_DIRECTION_BOTH, \
+            NULL, NULL);\
+        usb_device_manager_release( \
+            &instance->generic.dev_manager, hub_address); \
         return ret; \
 } else (void)0
-        ret = usb_endpoint_manager_add_ep(
-            &instance->generic.ep_manager, instance->rh.address, 0,
-            USB_DIRECTION_BOTH, USB_TRANSFER_CONTROL, USB_SPEED_FULL, 64,
-            0, NULL, NULL);
+        int ret = usb_endpoint_manager_add_ep(
+            &instance->generic.ep_manager, hub_address, 0, USB_DIRECTION_BOTH,
+            USB_TRANSFER_CONTROL, USB_SPEED_FULL, 64, 0, NULL, NULL);
         CHECK_RET_UNREG_RETURN(ret,
             "Failed to register root hub control endpoint: %s.\n",
@@ -195 +193 @@
         list_initialize(&instance->pending_batches);
 
-        hcd_init(&instance->generic, USB_SPEED_FULL,
-            BANDWIDTH_AVAILABLE_USB11, bandwidth_count_usb11);
+        hcd_init(&instance->generic, BANDWIDTH_AVAILABLE_USB11,
+            bandwidth_count_usb11);
         instance->generic.private_data = instance;
         instance->generic.schedule = hc_schedule;