Changeset 428bd07 in mainline

Timestamp:

2013-03-12T23:04:05Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

aaceebc4

Parents:

a05f2af

Message:

root, compositor: Be more verbose about errors

Location:

uspace

Files:

• drv/infrastructure/root/root.c (modified) (1 diff)
• srv/hid/compositor/compositor.c (modified) (4 diffs)

uspace/drv/infrastructure/root/root.c

@@ -208 +208 @@
         /*
          * Register virtual devices root.
-         * We ignore error occurrence because virtual devices shall not be
+         * We warn on error occurrence because virtual devices shall not be
          * vital for the system.
          */
-        (void) add_virtual_root_fun(dev);
+        int res = add_virtual_root_fun(dev);
+        if (res != EOK)
+                ddf_msg(LVL_WARN, "Failed to add virtual child.");
 
         /* Register root device's children. */
-        int res = add_platform_fun(dev);
+        res = add_platform_fun(dev);
         if (EOK != res)
                 ddf_msg(LVL_ERROR, "Failed adding child device for platform.");

uspace/srv/hid/compositor/compositor.c

@@ -2092 +2092 @@
         /* Establish input bidirectional connection. */
         rc = input_connect(input_svc);
-        if (rc != EOK)
+        if (rc != EOK) {
+                printf("%s: Failed to connect to input service.\n", NAME);
                 return rc;
+        }
 
         /* Create viewports and connect them to visualizers. */
@@ -2099 +2101 @@
         rc = loc_category_get_id("visualizer", &cat_id, IPC_FLAG_BLOCKING);
         if (rc != EOK) {
+                printf("%s: Failed to get visualizer category.\n", NAME);
                 input_disconnect();
                 return -1;
@@ -2107 +2110 @@
         rc = loc_category_get_svcs(cat_id, &svcs, &svcs_cnt);
         if (rc != EOK || svcs_cnt == 0) {
+                printf("%s: Failed to get visualizer category services.\n", NAME);
                 input_disconnect();
                 return -1;
@@ -2123 +2127 @@
         
         if (list_empty(&viewport_list)) {
+                printf("%s: Failed to get view ports.\n", NAME);
                 input_disconnect();
                 return -1;