Changes in / [c289457:3ce78580] in mainline

Location:

uspace

Files:

• drv/bus/pci/pciintel/pci.c (modified) (7 diffs)
• drv/bus/pci/pciintel/pci.h (modified) (1 diff)
• lib/drv/generic/driver.c (modified) (1 diff)

uspace/drv/bus/pci/pciintel/pci.c

@@ -225 +225 @@
         fibril_mutex_lock(&bus->conf_mutex);
         
-        const uint32_t conf_addr = CONF_ADDR(fun->bus, fun->dev, fun->fn, reg);
+        uint32_t conf_addr;
+        conf_addr = CONF_ADDR(fun->bus, fun->dev, fun->fn, reg);
         void *addr = bus->conf_data_port + (reg & 3);
         
@@ -310 +311 @@
 void pci_fun_create_match_ids(pci_fun_t *fun)
 {
-#define ID_MAX_STR_LEN 50 /* Max is 47, align to something nice. */
-
+        char *match_id_str;
         int rc;
-        char match_id_str[ID_MAX_STR_LEN];
-
-        /* Vendor ID & Device ID, length(incl \0) 22 */
-        rc = snprintf(match_id_str, ID_MAX_STR_LEN, "pci/ven=%04x&dev=%04x",
+        
+        asprintf(&match_id_str, "pci/ven=%04x&dev=%04x",
             fun->vendor_id, fun->device_id);
-        if (rc < 0) {
-                ddf_msg(LVL_ERROR, "Failed creating match ID str: %s",
-                    str_error(rc));
+
+        if (match_id_str == NULL) {
+                ddf_msg(LVL_ERROR, "Out of memory creating match ID.");
+                return;
         }
 
         rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 90);
         if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s", str_error(rc));
-        }
-
-        /* Class, subclass, prog IF, revision, length(incl \0) 47 */
-        rc = snprintf(match_id_str, ID_MAX_STR_LEN,
-            "pci/class=%02x&subclass=%02x&progif=%02x&revision=%02x",
-            fun->class_code, fun->subclass_code, fun->prog_if, fun->revision);
-        if (rc < 0) {
-                ddf_msg(LVL_ERROR, "Failed creating match ID str: %s",
+                ddf_msg(LVL_ERROR, "Failed adding match ID: %s",
                     str_error(rc));
         }
-
-        rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 70);
-        if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s", str_error(rc));
-        }
-
-        /* Class, subclass, prog IF, length(incl \0) 35 */
-        rc = snprintf(match_id_str, ID_MAX_STR_LEN,
-            "pci/class=%02x&subclass=%02x&progif=%02x",
-            fun->class_code, fun->subclass_code, fun->prog_if);
-        if (rc < 0) {
-                ddf_msg(LVL_ERROR, "Failed creating match ID str: %s",
-                    str_error(rc));
-        }
-
-        rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 60);
-        if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s", str_error(rc));
-        }
-
-        /* Class, subclass, length(incl \0) 25 */
-        rc = snprintf(match_id_str, ID_MAX_STR_LEN,
-            "pci/class=%02x&subclass=%02x",
-            fun->class_code, fun->subclass_code);
-        if (rc < 0) {
-                ddf_msg(LVL_ERROR, "Failed creating match ID str: %s",
-                    str_error(rc));
-        }
-
-        rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 50);
-        if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s", str_error(rc));
-        }
-
-        /* Class, length(incl \0) 13 */
-        rc = snprintf(match_id_str, ID_MAX_STR_LEN, "pci/class=%02x",
-            fun->class_code);
-        if (rc < 0) {
-                ddf_msg(LVL_ERROR, "Failed creating match ID str: %s",
-                    str_error(rc));
-        }
-
-        rc = ddf_fun_add_match_id(fun->fnode, match_id_str, 40);
-        if (rc != EOK) {
-                ddf_msg(LVL_ERROR, "Failed adding match ID: %s", str_error(rc));
-        }
-
-        /* TODO add subsys ids, but those exist only in header type 0 */
+        
+        free(match_id_str);
+        
+        /* TODO add more ids (with subsys ids, using class id etc.) */
 }
 
@@ -534 +481 @@
                 for (fnum = 0; multi && fnum < 8; fnum++) {
                         pci_fun_init(fun, bus_num, dnum, fnum);
+                        fun->vendor_id = pci_conf_read_16(fun,
+                            PCI_VENDOR_ID);
+                        fun->device_id = pci_conf_read_16(fun,
+                            PCI_DEVICE_ID);
                         if (fun->vendor_id == 0xffff) {
                                 /*
@@ -560 +511 @@
                         
                         fnode = ddf_fun_create(bus->dnode, fun_inner, fun_name);
-                        free(fun_name);
                         if (fnode == NULL) {
                                 ddf_msg(LVL_ERROR, "Failed creating function.");
@@ -566 +516 @@
                         }
                         
+                        free(fun_name);
                         fun->fnode = fnode;
                         
@@ -740 +691 @@
         fun->dev = dev;
         fun->fn = fn;
-        fun->vendor_id = pci_conf_read_16(fun, PCI_VENDOR_ID);
-        fun->device_id = pci_conf_read_16(fun, PCI_DEVICE_ID);
-        fun->class_code = pci_conf_read_8(fun, PCI_BASE_CLASS);
-        fun->subclass_code = pci_conf_read_8(fun, PCI_SUB_CLASS);
-        fun->prog_if = pci_conf_read_8(fun, PCI_PROG_IF);
-        fun->revision = pci_conf_read_8(fun, PCI_REVISION_ID);
 }
 
@@ -766 +711 @@
 bool pci_alloc_resource_list(pci_fun_t *fun)
 {
-        fun->hw_resources.resources = fun->resources;
-        return true;
+        fun->hw_resources.resources =
+            (hw_resource_t *) malloc(PCI_MAX_HW_RES * sizeof(hw_resource_t));
+        return fun->hw_resources.resources != NULL;
 }
 
 void pci_clean_resource_list(pci_fun_t *fun)
 {
-        fun->hw_resources.resources = NULL;
+        if (fun->hw_resources.resources != NULL) {
+                free(fun->hw_resources.resources);
+                fun->hw_resources.resources = NULL;
+        }
 }
 

uspace/drv/bus/pci/pciintel/pci.h

@@ -60 +60 @@
         int vendor_id;
         int device_id;
-        uint8_t class_code;
-        uint8_t subclass_code;
-        uint8_t prog_if;
-        uint8_t revision;
         hw_resource_list_t hw_resources;
-        hw_resource_t resources[PCI_MAX_HW_RES];
 } pci_fun_t;
 

uspace/lib/drv/generic/driver.c

@@ -970 +970 @@
         
         match_id->id = str_dup(match_id_str);
-        match_id->score = match_score;
+        match_id->score = 90;
         
         add_match_id(&fun->match_ids, match_id);