Changeset 3648ea56 in mainline

Timestamp:

2012-07-30T19:20:21Z (12 years ago)

Author:

Adam Hraska <adam.hraska+hos@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

09737cc

Parents:

452e91b

Message:

rcu: Cosmetic change. Shaved off some overhead in rcu_call().

File:

• kernel/generic/src/synch/rcu.c (modified) (4 diffs)

kernel/generic/src/synch/rcu.c

@@ -164 +164 @@
 static void start_reclaimers(void);
 static void synch_complete(rcu_item_t *rcu_item);
+static inline void rcu_call_impl(bool expedite, rcu_item_t *rcu_item, 
+        rcu_func_t func);
 static void add_barrier_cb(void *arg);
 static void barrier_complete(rcu_item_t *barrier_item);
@@ -565 +567 @@
 void rcu_call(rcu_item_t *rcu_item, rcu_func_t func)
 {
-        _rcu_call(false, rcu_item, func);
+        rcu_call_impl(false, rcu_item, func);
 }
 
@@ -571 +573 @@
 void _rcu_call(bool expedite, rcu_item_t *rcu_item, rcu_func_t func)
 {
+        rcu_call_impl(expedite, rcu_item, func);
+}
+
+/** rcu_call() inline-able implementation. See rcu_call() for comments. */
+static inline void rcu_call_impl(bool expedite, rcu_item_t *rcu_item, 
+        rcu_func_t func)
+{
         ASSERT(rcu_item);
         
@@ -580 +589 @@
         ipl_t ipl = interrupts_disable();
 
-        *CPU->rcu.parriving_cbs_tail = rcu_item;
-        CPU->rcu.parriving_cbs_tail = &rcu_item->next;
-        
-        size_t cnt = ++CPU->rcu.arriving_cbs_cnt;
+        rcu_cpu_data_t *r = &CPU->rcu;
+        *r->parriving_cbs_tail = rcu_item;
+        r->parriving_cbs_tail = &rcu_item->next;
+        
+        size_t cnt = ++r->arriving_cbs_cnt;
         interrupts_restore(ipl);
         
         if (expedite) {
-                CPU->rcu.expedite_arriving = true;
+                r->expedite_arriving = true;
         }
         
         /* Added first callback - notify the reclaimer. */
-        if (cnt == 1 && !semaphore_count_get(&CPU->rcu.arrived_flag)) {
-                semaphore_up(&CPU->rcu.arrived_flag);
+        if (cnt == 1 && !semaphore_count_get(&r->arrived_flag)) {
+                semaphore_up(&r->arrived_flag);
         }