Changeset 33fc3ae in mainline

Timestamp:

2012-07-09T16:33:43Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a8435881, b4ca0a9c, f0348c8

Parents:

5e4f22b

Message:

Do not leak a fun_node_t reference in devman_add_function()
when trying to add the same function for the second time.

File:

• uspace/srv/devman/main.c (modified) (1 diff)

uspace/srv/devman/main.c

@@ -419 +419 @@
         
         /* Check that function with same name is not there already. */
-        if (find_fun_node_in_device(tree, pdev, fun_name) != NULL) {
+        fun_node_t *tfun = find_fun_node_in_device(tree, pdev, fun_name);
+        if (tfun) {
+                fun_del_ref(tfun);      /* drop the new unwanted reference */
                 fibril_rwlock_write_unlock(&tree->rwlock);
                 dev_del_ref(pdev);