Changeset 296fcce in mainline

Timestamp:

2014-01-24T20:44:51Z (10 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fdaaad00

Parents:

0a751aa

Message:

ehci: Don't use prepend in async list.

Hw uses RR anyway.

Location:

uspace/drv/bus/usb/ehci

Files:

• endpoint_list.c (modified) (1 diff)
• endpoint_list.h (modified) (1 diff)
• hc.c (modified) (1 diff)

uspace/drv/bus/usb/ehci/endpoint_list.c

@@ -122 +122 @@
 }
 
-/** Add endpoint to the beginning of the list and queue.
- *
- * @param[in] instance List to use.
- * @param[in] endpoint Endpoint to add.
- *
- * The endpoint is added to the end of the list and queue.
- */
-void endpoint_list_prepend_ep(endpoint_list_t *instance, ehci_endpoint_t *ep)
-{
-        assert(instance);
-        assert(ep);
-        assert(ep->qh);
-        usb_log_debug2("Queue %s: Prepend endpoint(%p).\n", instance->name, ep);
-
-        fibril_mutex_lock(&instance->guard);
-        ep->qh->horizontal = instance->list_head->horizontal;
-        /* Make sure QH is updated */
-        write_barrier();
-        /* Add QH to the hw queue */
-        qh_append_qh(instance->list_head, ep->qh);
-        /* Add to the sw list */
-        list_prepend(&ep->link, &instance->endpoint_list);
-        fibril_mutex_unlock(&instance->guard);
-
-}
 /** Remove endpoint from the list and queue.
  *

uspace/drv/bus/usb/ehci/endpoint_list.h

@@ -74 +74 @@
 int endpoint_list_init(endpoint_list_t *instance, const char *name);
 void endpoint_list_append_ep(endpoint_list_t *instance, ehci_endpoint_t *ep);
-void endpoint_list_prepend_ep(endpoint_list_t *instance, ehci_endpoint_t *ep);
 void endpoint_list_remove_ep(endpoint_list_t *instance, ehci_endpoint_t *ep);
 #endif

uspace/drv/bus/usb/ehci/hc.c

@@ -215 +215 @@
         {
         case USB_TRANSFER_CONTROL:
-                endpoint_list_prepend_ep(&instance->async_list, ehci_ep);
-                break;
         case USB_TRANSFER_BULK:
                 endpoint_list_append_ep(&instance->async_list, ehci_ep);