Changeset 290338b in mainline

Timestamp:

2018-02-01T20:37:38Z (6 years ago)

Author:

Petr Manek <petr.manek@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

64ce0c1

Parents:

3038d51

git-author:

Petr Manek <petr.manek@…> (2018-02-01 20:37:00)

git-committer:

Petr Manek <petr.manek@…> (2018-02-01 20:37:38)

Message:

usbdiag: more verbose data checking

File:

• uspace/drv/bus/usb/usbdiag/tests.c (modified) (2 diffs)

uspace/drv/bus/usb/usbdiag/tests.c

@@ -60 +60 @@
                 return EINVAL;
 
+        size_t test_data_size = size / sizeof(test_data);
         char *buffer = (char *) malloc(size);
         if (!buffer)
@@ -104 +105 @@
 
                 if (validate) {
-                        for (size_t i = 0; i < size; i += sizeof(test_data)) {
-                                if (*(uint32_t *)(buffer + i) != test_data) {
+                        uint32_t *beef_buffer = (uint32_t *) buffer;
+
+                        /* Check if the beef is really dead. */
+                        for (size_t i = 0; i < test_data_size; ++i) {
+                                if (beef_buffer[i] != test_data) {
                                         usb_log_error("Read of %s IN endpoint returned "
-                                                "invald data at address %zu.",
-                                                usb_str_transfer_type(pipe->desc.transfer_type), i);
+                                                "invalid data at address %zu. [ 0x%X != 0x%X ]",
+                                                usb_str_transfer_type(pipe->desc.transfer_type), i * sizeof(test_data), beef_buffer[i], test_data);
                                         rc = EINVAL;
-                                        break;
                                 }
                         }