Changes in uspace/lib/c/generic/fibril_synch.c [7f9d97f3:2654afb] in mainline

File:

• uspace/lib/c/generic/fibril_synch.c (modified) (7 diffs)

uspace/lib/c/generic/fibril_synch.c

@@ -105 +105 @@
         fibril_t *f = (fibril_t *) fibril_get_id();
 
-        if (fibril_get_sercount() != 0)
-                abort();
-
         futex_down(&async_futex);
         if (fm->counter-- <= 0) {
@@ -197 +194 @@
         fibril_t *f = (fibril_t *) fibril_get_id();
         
-        if (fibril_get_sercount() != 0)
-                abort();
-
         futex_down(&async_futex);
         if (frw->writers) {
@@ -224 +218 @@
         fibril_t *f = (fibril_t *) fibril_get_id();
         
-        if (fibril_get_sercount() != 0)
-                abort();
-
         futex_down(&async_futex);
         if (frw->writers || frw->readers) {
@@ -461 +452 @@
                         if (rc == ETIMEOUT && timer->state == fts_active) {
                                 timer->state = fts_fired;
-                                timer->handler_running = true;
+                                timer->handler_fid = fibril_get_id();
                                 fibril_mutex_unlock(timer->lockp);
                                 timer->fun(timer->arg);
                                 fibril_mutex_lock(timer->lockp);
-                                timer->handler_running = false;
+                                timer->handler_fid = 0;
                         }
                         break;
@@ -477 +468 @@
         /* Acknowledge timer fibril has finished cleanup. */
         timer->state = fts_clean;
+        fibril_condvar_broadcast(&timer->cv);
         fibril_mutex_unlock(timer->lockp);
-        free(timer);
 
         return 0;
@@ -525 +516 @@
         timer->state = fts_cleanup;
         fibril_condvar_broadcast(&timer->cv);
+
+        /* Wait for timer fibril to terminate */
+        while (timer->state != fts_clean)
+                fibril_condvar_wait(&timer->cv, timer->lockp);
         fibril_mutex_unlock(timer->lockp);
+
+        free(timer);
 }
 
@@ -608 +605 @@
         assert(fibril_mutex_is_locked(timer->lockp));
 
-        while (timer->handler_running)
+        while (timer->handler_fid != 0) {
+                if (timer->handler_fid == fibril_get_id()) {
+                        printf("Deadlock detected.\n");
+                        stacktrace_print();
+                        printf("Fibril %zx is trying to clear timer %p from "
+                            "inside its handler %p.\n",
+                            fibril_get_id(), timer, timer->fun);
+                        abort();
+                }
+
                 fibril_condvar_wait(&timer->cv, timer->lockp);
+        }
 
         old_state = timer->state;