Changeset 0eea807 in mainline

Timestamp:

2023-10-22T13:56:55Z (7 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1502c05

Parents:

f5762c7

git-author:

Vojtech Horky <vojtech.horky@…> (2023-07-24 16:30:23)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-10-22 13:56:55)

Message:

Remove memory leak

File:

• uspace/app/wifi_supplicant/wifi_supplicant.c (modified) (2 diffs)

uspace/app/wifi_supplicant/wifi_supplicant.c

@@ -75 +75 @@
 }
 
-static char *nic_addr_format(nic_address_t *addr)
-{
-        char *str;
-        int rc = asprintf(&str, "%02x:%02x:%02x:%02x:%02x:%02x",
+static void nic_addr_format(nic_address_t *addr, char *out, size_t out_size)
+{
+        snprintf(out, out_size, "%02x:%02x:%02x:%02x:%02x:%02x",
             addr->address[0], addr->address[1], addr->address[2],
             addr->address[3], addr->address[4], addr->address[5]);
-
-        if (rc < 0)
-                return NULL;
-
-        return str;
 }
 
@@ -263 +257 @@
         for (uint8_t i = 0; i < scan_results.length; i++) {
                 ieee80211_scan_result_t result = scan_results.results[i];
+                char mac_addr_hex[18];
+                nic_addr_format(&result.bssid, mac_addr_hex, 18);
 
                 printf("%16.16s %17s %4d %5s %5s %7s %7s\n",
-                    result.ssid, nic_addr_format(&result.bssid),
+                    result.ssid, mac_addr_hex,
                     result.channel,
                     enum_name(ieee80211_security_type_strs, result.security.type),