#837 closed defect (fixed)
Build error on Fedora 34
| Reported by: | Jakub Jermář | Owned by: | Jiří Zárevúcky |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | helenos-build | Version: | mainline |
| Keywords: | Cc: | ||
| Blocker for: | Depends on: | ||
| See also: |
Description
On my Fedora 34 I started getting the following build error on the recent master branch and new build directory:
[1346/2023] Compiling C object uspace/app_launcher.p/app_launcher_launcher.c.o
FAILED: uspace/app_launcher.p/app_launcher_launcher.c.o
/usr/local/cross/bin/amd64-helenos-gcc -Iuspace/app_launcher.p -I../helenos/uspace/lib/gfximage/include -I../helenos/uspace/lib/gfx/include -Iuspace/lib/pixconv -I../helenos/uspace/lib/pixconv -Iuspace/lib/compress -I../helenos/uspace/lib/compress -I../helenos/uspace/lib/ui/include -I../helenos/uspace/lib/gfxfont/include -I../helenos/uspace/lib/riff/include -I../helenos/uspace/lib/memgfx/include -I../helenos/uspace/lib/display/include -I../helenos/uspace/lib/ipcgfx/include -I../helenos/uspace/lib/congfx/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -imacros /home/jermar/software/HelenOS/build-amd64/config.h -O3 -fexec-charset=UTF-8 -finput-charset=UTF-8 -D_HELENOS_SOURCE -Wa,--fatal-warnings -Wall -Wextra -Werror-implicit-function-declaration -Wwrite-strings -Wunknown-pragmas -Wno-unused-parameter -pipe -ffunction-sections -fno-common -fdebug-prefix-map=/home/jermar/software/HelenOS/helenos=. -Wsystem-headers -fvar-tracking-assignments -Werror -Wmissing-prototypes -Wno-missing-braces -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-nonnull-compare -fno-builtin-strftime -isystem../helenos/abi/include -isystem../helenos/abi/arch/amd64/include -isystem../helenos/uspace/lib/c/arch/amd64/include -isystem../helenos/uspace/lib/c/include -D__LE__ -fno-omit-frame-pointer -MD -MQ uspace/app_launcher.p/app_launcher_launcher.c.o -MF uspace/app_launcher.p/app_launcher_launcher.c.o.d -o uspace/app_launcher.p/app_launcher_launcher.c.o -c ../helenos/uspace/app/launcher/launcher.c
../helenos/uspace/app/launcher/launcher.c:53:10: fatal error: images.h: No such file or directory
#include "images.h"
^~~~~~~~~~
compilation terminated.
[1355/2023] Compiling C object uspace/app_mkexfat.p/app_mkexfat_mkexfat.c.o
ninja: build stopped: subcommand failed.
I have meson 0.59.0 and ninja 1.10.2.
Change History (6)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:4 by , 3 years ago
This was caused by a change in Meson 0.58.0.
Fixed in https://github.com/HelenOS/helenos/commit/cd981f2ab573f6154bc4872d06b8deb9c9bb9530
comment:5 by , 3 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
By comparing the command line used for translating launcher on older Fedora and Fedora 34, it turns out that on Fedora 34 the command line is missing the
-Iuspace/app/launcheroption and so the compiler doesn't know where to find images.h.On the old Fedora, this option is included right before the
-fdiagnostics-color=alwaysoption, but is missing on Fedora 34.Good cmd line from old Fedora:
Fedora 34: