Sysinfo mapping of OFW properties is broken

[Jiri Svoboda]

It appears OFW device nodes are mapped to sysinfo nodes having names like firmware..something (note the double period). An attempt to dump the node properties via userspace sysinfo command (either sysinfo firmware.something or sysinfo firmware..something) fails, saying the property does not exist.

[Jakub Jermář]

On ppc32, I can successfully dump firmware..packages.cmdline and firmware..aliases. The confusion seems to stem from the fact that the root of the ofw tree is called (empty name) and sysinfo uses . as a separator. So we need to type firmware..aliases to name ofw's /aliases.

[Jiri Svoboda]

Not sure why I wasn't able to dump it before, it works for me now, e.g. firmware..aliases. Would it make sense to change the mapping to omit the extra period, e.g. just firmware.aliases? Or is it possible for the root node to have non-empty name?

[Jakub Jermář]

I fixed this in commit 063a364794dc48510948ecc3cf9196cd0a7cee9e by renaming the root node to 'ofw'.

[Jiri Svoboda]

Thanks. What I meant was, if IEEE 1275 allowed the root node to have non-empty name, thus possibly creating a situation where we actually wanted to reflect the actual name of the node in the sysinfo tree. I guess the answer is no?

[Jakub Jermář]

The change I made would create 'firmware.foobar' for an OFW root node called 'foobar'. The difference is the non-empty name. For consistency, we might change this to create 'firmware.foobar.ofw-foobar', not sure.

[Jiri Svoboda]

The way I read the standard the root node can't have non-empty name, so I think we're okay.