Opened 6 years ago
Closed 6 years ago
#766 closed defect (fixed)
Non-debug build fails
| Reported by: | Jiri Svoboda | Owned by: | Jakub Jermář |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.0 |
| Component: | helenos/kernel/generic | Version: | mainline |
| Keywords: | Cc: | ||
| Blocker for: | Depends on: | ||
| See also: |
Description
As of revision aaa3c4571e7747f21c303ea4c746fe2ef17a5ae8, non-debug build of the OS fails with:
generic/include/synch/spinlock.h:101:32: error: implicit declaration of function 'atomic_lock_arch'; did you mean 'atomic_is_lock_free'? [-Werror=implicit-function-declaration]
#define spinlock_lock(lock) atomic_lock_arch(&(lock)->val)
^~~~~~~~~~~~~~~~
genarch/src/fb/fb.c:414:2: note: in expansion of macro 'spinlock_lock'
spinlock_lock(&instance->lock);
^~~~~~~~~~~~~
...
}
Change History (3)
comment:1 by , 6 years ago
| Component: | helenos/unspecified → helenos/kernel/generic |
|---|---|
| Owner: | set to |
comment:2 by , 6 years ago
comment:3 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in commit 543662b3a5a91cc3b12c5ff897d1940f7a0248fc.
Note:
See TracTickets
for help on using tickets.
Git bisect reveals that:
4621d2311994bf63dea425ed923239d4ca1babc9 is the first bad commit commit 4621d2311994bf63dea425ed923239d4ca1babc9 Author: Jiří Zárevúcky <jiri.zarevucky@nic.cz> Date: Mon Aug 13 05:00:17 2018 +0200 Use compiler builtins for kernel atomics