Opened 14 years ago
Closed 13 years ago
#278 closed defect (fixed)
ip_header.h confuses bit order with byte order
Reported by: | Jiri Svoboda | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 0.5.0 |
Component: | helenos/net/inet | Version: | |
Keywords: | Cc: | ||
Blocker for: | Depends on: | ||
See also: |
Description
ip_header.h incorrectly uses the ARCH_IS_BIG_ENDIAN macro to detect whether C bitfields are stored in high-to-low or low-to-high order. This is incorrect, because bitfield order has nothing to do with byte order (ARCH_IS_BIG_ENDIAN tells us byte order is big-endian).
Either we need to supply macros for checking bitfield order, or, preferably, avoid bit fields like in the rest of the code.
Change History (2)
comment:1 by , 14 years ago
Milestone: | 0.4.3 → 0.5.0 |
---|
comment:2 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Fixed in mainline,997.