Changeset feeac0d in mainline for uspace/srv/net/dnsrsrv

Timestamp:

2013-09-10T16:32:35Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4982d87

Parents:

e8d6ce2

Message:

Simplify use of list_foreach.

Location:

uspace/srv/net/dnsrsrv

Files:

• dns_msg.c (modified) (2 diffs)
• query.c (modified) (1 diff)
• transport.c (modified) (1 diff)

uspace/srv/net/dnsrsrv/dns_msg.c

@@ -510 +510 @@
         size = sizeof(dns_header_t);
 
-        list_foreach(msg->question, link) {
-                dns_question_t *q = list_get_instance(link, dns_question_t, msg);
+        list_foreach(msg->question, msg, dns_question_t, q) {
                 rc = dns_question_encode(q, NULL, 0, &q_size);
                 if (rc != EOK)
@@ -526 +525 @@
         di = sizeof(dns_header_t);
 
-        list_foreach(msg->question, link) {
-                dns_question_t *q = list_get_instance(link, dns_question_t, msg);
+        list_foreach(msg->question, msg, dns_question_t, q) {
                 rc = dns_question_encode(q, data + di, size - di, &q_size);
                 if (rc != EOK) {

uspace/srv/net/dnsrsrv/query.c

@@ -99 +99 @@
         }
         
-        list_foreach(amsg->answer, link) {
-                dns_rr_t *rr = list_get_instance(link, dns_rr_t, msg);
-                
+        list_foreach(amsg->answer, msg, dns_rr_t, rr) {
                 log_msg(LOG_DEFAULT, LVL_DEBUG, " - '%s' %u/%u, dsize %zu",
                     rr->name, rr->rtype, rr->rclass, rr->rdata_size);

uspace/srv/net/dnsrsrv/transport.c

@@ -158 +158 @@
         assert(fibril_mutex_is_locked(&treq_lock));
 
-        list_foreach(treq_list, link) {
-                trans_req_t *treq = list_get_instance(link, trans_req_t, lreq);
-
+        list_foreach(treq_list, lreq, trans_req_t, treq) {
                 if (treq->req->id == resp->id) {
                         /* Match */