Changeset feeac0d in mainline for uspace/lib/usbhid/src/hidparser.c

Timestamp:

2013-09-10T16:32:35Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4982d87

Parents:

e8d6ce2

Message:

Simplify use of list_foreach.

File:

• uspace/lib/usbhid/src/hidparser.c (modified) (13 diffs)

uspace/lib/usbhid/src/hidparser.c

@@ -130 +130 @@
     size_t size, uint8_t *report_id)
 {
-        usb_hid_report_field_t *item;
-
         usb_hid_report_description_t *report_des;
         usb_hid_report_type_t type = USB_HID_REPORT_TYPE_INPUT;
-        
+
         if (report == NULL) {
                 return EINVAL;
@@ -153 +151 @@
 
         /* read data */
-        list_foreach(report_des->report_items, list_item) {
-                item = list_get_instance(list_item, usb_hid_report_field_t, 
-                    ritems_link);
+        list_foreach(report_des->report_items, ritems_link,
+            usb_hid_report_field_t, item) {
 
                 if (USB_HID_ITEM_FLAG_CONSTANT(item->item_flags) == 0) {
-                        
+
                         if (USB_HID_ITEM_FLAG_VARIABLE(item->item_flags) == 0) {
                                 /* array */
                                 item->value = 
                                         usb_hid_translate_data(item, data);
-                
+
                                 item->usage = USB_HID_EXTENDED_USAGE(
                                     item->usages[item->value -
@@ -184 +181 @@
                                 /* variable item */
                                 item->value = usb_hid_translate_data(item, 
-                                    data);                              
-                        }                       
+                                    data);
+                        }
                 }
         }
-        
+
         return EOK;
 }
@@ -295 +292 @@
         usb_hid_report_description_t *report_des = NULL;
 
-        list_foreach(report->reports, report_it) {
-                report_des = list_get_instance(report_it,
-                    usb_hid_report_description_t, reports_link);
-                
+        list_foreach(report->reports, reports_link,
+            usb_hid_report_description_t, report_des) {
                 if ((report_des->report_id == report_id) &&
                     (report_des->type == USB_HID_REPORT_TYPE_OUTPUT)) {
@@ -345 +340 @@
         int length;
         int32_t tmp_value;
-        
+
         if (report == NULL) {
                 return EINVAL;
@@ -351 +346 @@
 
         if (report->use_report_ids != 0) {
-                buffer[0] = report_id;          
+                buffer[0] = report_id;
         }
 
@@ -357 +352 @@
         report_des = usb_hid_report_find_description(report, report_id, 
             USB_HID_REPORT_TYPE_OUTPUT);
-        
+
         if (report_des == NULL) {
                 return EINVAL;
         }
 
-        usb_hid_report_field_t *report_item;
-
-        list_foreach(report_des->report_items, item) {
-                report_item = list_get_instance(item, usb_hid_report_field_t,
-                    ritems_link);
-
+        list_foreach(report_des->report_items, ritems_link,
+            usb_hid_report_field_t, report_item) {
                 value = usb_hid_translate_data_reverse(report_item, 
                     report_item->value);
@@ -373 +364 @@
                 offset = report_des->bit_length - report_item->offset - 1;
                 length = report_item->size;
-                
+
                 usb_log_debug("\ttranslated value: %x\n", value);
 
@@ -382 +373 @@
                         }
                         size_t shift = 8 - offset % 8 - length;
-                        value = value << shift;                                                 
+                        value = value << shift;
                         value = value & (((1 << length) - 1) << shift);
-                                
+
                         uint8_t mask = 0;
                         mask = 0xff - (((1 << length) - 1) << shift);
@@ -400 +391 @@
 
                                         tmp_value = tmp_value << (offset % 8);
-        
+
                                         mask = ~(((1 << (8 - (offset % 8))) - 1)
                                             << (offset % 8));
@@ -407 +398 @@
                                             tmp_value;
                                 } else if (i == ((offset + length - 1) / 8)) {
-                                        
+
                                         value = value >> (length - 
                                             ((offset + length) % 8));
@@ -413 +404 @@
                                         value = value & ((1 << (length - 
                                             ((offset + length) % 8))) - 1);
-                                
+
                                         mask = (1 << (length - 
                                             ((offset + length) % 8))) - 1;
@@ -427 +418 @@
                 report_item->value = 0;
         }
-        
+
         return EOK;
 }