Changeset feeac0d in mainline for kernel/generic/src/console

Timestamp:

2013-09-10T16:32:35Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4982d87

Parents:

e8d6ce2

Message:

Simplify use of list_foreach.

Location:

kernel/generic/src/console

Files:

• cmd.c (modified) (3 diffs)
• console.c (modified) (2 diffs)
• kconsole.c (modified) (2 diffs)

kernel/generic/src/console/cmd.c

@@ -656 +656 @@
         
         size_t len = 0;
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                hlp = list_get_instance(cur, cmd_info_t, link);
-                
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 if (str_length(hlp->name) > len)
@@ -672 +669 @@
         }
         
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                hlp = list_get_instance(cur, cmd_info_t, link);
-                
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 printf("%-*s %s\n", _len, hlp->name, hlp->description);
@@ -912 +906 @@
         spinlock_lock(&cmd_lock);
         
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp;
-                
-                hlp = list_get_instance(cur, cmd_info_t, link);
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);
                 

kernel/generic/src/console/console.c

@@ -125 +125 @@
 static void stdout_write(outdev_t *dev, wchar_t ch)
 {
-        list_foreach(dev->list, cur) {
-                outdev_t *sink = list_get_instance(cur, outdev_t, link);
+        list_foreach(dev->list, link, outdev_t, sink) {
                 if ((sink) && (sink->op->write))
                         sink->op->write(sink, ch);
@@ -134 +133 @@
 static void stdout_redraw(outdev_t *dev)
 {
-        list_foreach(dev->list, cur) {
-                outdev_t *sink = list_get_instance(cur, outdev_t, link);
+        list_foreach(dev->list, link, outdev_t, sink) {
                 if ((sink) && (sink->op->redraw))
                         sink->op->redraw(sink);

kernel/generic/src/console/kconsole.c

@@ -118 +118 @@
          * Make sure the command is not already listed.
          */
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp = list_get_instance(cur, cmd_info_t, link);
-                
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 if (hlp == cmd) {
                         /* The command is already there. */
@@ -612 +610 @@
         cmd_info_t *cmd = NULL;
         
-        list_foreach(cmd_list, cur) {
-                cmd_info_t *hlp = list_get_instance(cur, cmd_info_t, link);
+        list_foreach(cmd_list, link, cmd_info_t, hlp) {
                 spinlock_lock(&hlp->lock);