Changeset fdf97f6 in mainline for uspace/app

Timestamp:

2013-02-25T19:11:50Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1935591

Parents:

c84f1a4

Message:

Libposix functions are without posix_ prefix

Prior this commit, libposix headers declared all functions as posix_*
and used macros to rename e.g. strncpy to posix_strncpy in all (ported)
sources.

After this change, libposix headers look as normal POSIX compliant headers
(well, almost) and no renaming is done in the source codei (of the ported
applications). Instead, the renaming is done at object files level to
bypass weird problems that are bound to happen if you use macros.

The scheme is following. libposix headers use special macro to declare
the names. When included from outside, the functions have their normal
(standard) names. When included from the libposix sources, posix_ prefix
is added. Thus, when libposix is compiled and linked, it contains the
posix_* naming while compiling of ported software uses the normal
non-prefixed versions. This way the posix_* can use HelenOS libc without
any problem. Before linking, the posix_* prefix is removed from all
symbols and special prefix helenos_libc_ is added to all functions
that exists in our (HelenOS) libc and its name clashes with the POSIX
one.

The following happens, for example, to the open() function that exists in
both libposix and in libc.

• Headers and sources of libc are left intact.
• Copy of libc.a is made and to all clashing functions is added the helenos_libc prefix. This library is called libc4posix.a.
• POSIX_DEF(open)(const char *) is used in libposix headers. This macro expands to plain open when included from the "outside world". But it expands to posix_open when included from libposix sources.
• Libposix is compiled and linked, containing posix_open() that internally calls open() [the original one from libc].
• Libposix is transformed - all open() are replaced with prefix variant: helenos_libc_open() and all posix_open() are replaced with open(). The transformed library is stored as libposixaslibc.a

Binutils and PCC are then linked with libc4posix and libposixaslibc
libraries instead of libc and libposix as was done previously.

WARNING: it looks that binutils, PCC and MSIM still works but not all
architectures were tested.

Location:

uspace/app

Files:

• binutils/intrusive.sh (modified) (2 diffs)
• pcc/config.h (modified) (1 diff)

uspace/app/binutils/intrusive.sh

@@ -96 +96 @@
 # libposix function name redefinitons in one of the arm-specific files.
 #
+# Patch 9
+# Libiberty does not trust our strncmp that is provided in libposix.
+# That is because when cross-compiling, it cannot check how it behaves
+# and assumes the worst. But then it clashes when linking (due to
+# multiple definitions of ...) and this patch prevents compilation of
+# liberty strncmp.
 
 case "$1" in
@@ -157 +163 @@
                 # Patch libiberty configure script.
                 cat "$2/libiberty/configure.backup" | \
-                # See Patch 1.
-                sed 's/^cross_compiling=no/cross_compiling=yes/g' \
+                # See Patch 1 and 9.
+                sed -e 's/^cross_compiling=no/cross_compiling=yes/g' \
+                        -e 's/ac_cv_func_strncmp_works=no/ac_cv_func_strncmp_works=yes/g' \
                 > "$2/libiberty/configure"
 

uspace/app/pcc/config.h

@@ -50 +50 @@
 
 /* Define to 1 if you have the `mkstemp' function. */
-//#define HAVE_MKSTEMP 1
+#define HAVE_MKSTEMP 1
 
 /* Define to 1 if you have the `snprintf' function. */