Changeset fbefd0e in mainline for uspace/drv/uhci-rhd

Timestamp:

2011-03-21T18:14:30Z (15 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5f80527, ce794342

Parents:

215b001

Message:

USB drivers less verbose on info level

Location:

uspace/drv/uhci-rhd

Files:

• main.c (modified) (5 diffs)
• port.c (modified) (3 diffs)

uspace/drv/uhci-rhd/main.c

@@ -36 +36 @@
 #include <device/hw_res.h>
 #include <errno.h>
+#include <str_error.h>
 #include <usb_iface.h>
 #include <usb/ddfiface.h>
@@ -86 +87 @@
         int ret = hc_get_my_registers(device, &io_regs, &io_size);
         if (ret != EOK) {
-                usb_log_error("Failed(%d) to get registers from parent hc.",
-                    ret);
-        }
-        usb_log_info("I/O regs at %#X (size %zu).\n", io_regs, io_size);
+                usb_log_error("Failed to get registers from parent HC: %s.\n",
+                    str_error(ret));
+        }
+        usb_log_debug("I/O regs at %#X (size %zu).\n", io_regs, io_size);
 
         uhci_root_hub_t *rh = malloc(sizeof(uhci_root_hub_t));
@@ -99 +100 @@
         ret = uhci_root_hub_init(rh, (void*)io_regs, io_size, device);
         if (ret != EOK) {
-                usb_log_error("Failed(%d) to initialize driver instance.\n", ret);
+                usb_log_error("Failed to initialize driver instance: %s.\n",
+                    str_error(ret));
                 free(rh);
                 return ret;
@@ -105 +107 @@
 
         device->driver_data = rh;
-        usb_log_info("Sucessfully initialized driver instance for device:%d.\n",
-            device->handle);
+        usb_log_info("Controlling root hub `%s' (%llu).\n",
+            device->name, device->handle);
         return EOK;
 }
@@ -129 +131 @@
 int main(int argc, char *argv[])
 {
+        printf(NAME ": HelenOS UHCI root hub driver.\n");
+
         usb_log_enable(USB_LOG_LEVEL_DEFAULT, NAME);
+
         return ddf_driver_main(&uhci_rh_driver);
 }

uspace/drv/uhci-rhd/port.c

@@ -256 +256 @@
         assert(usb_hc_connection_is_opened(&port->hc_connection));
 
-        usb_log_info("%s: Detected new device.\n", port->id_string);
+        usb_log_debug("%s: Detected new device.\n", port->id_string);
 
         usb_address_t dev_addr;
@@ -270 +270 @@
         }
 
-        usb_log_info("%s: New device has address %d (handle %zu).\n",
-            port->id_string, dev_addr, port->attached_device);
+        usb_log_info("New device at port %u, address %d (handle %llu).\n",
+            port->number, dev_addr, port->attached_device);
 
         return EOK;
@@ -315 +315 @@
         uhci_port_write_status(port, port_status);
 
-        usb_log_info("%s: %sabled port.\n",
+        usb_log_debug("%s: %sabled port.\n",
                 port->id_string, enabled ? "En" : "Dis");
         return EOK;