Changeset f7a90df in mainline for uspace/lib/display

Timestamp:

2020-10-25T19:20:57Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d284ce9

Parents:

5a43bd0

Message:

Prototype UI and window classes

It is difficult to do any useful testing on ui_window without a real
display_t. Without display, there is no window, without window no GC,
without GC no UI resource.

As a compromise, in case of unit test, create UI with display == NULL,
in which case create window with NULL dwindow and a dummy GC
(so we have valid UI resource).

Location:

uspace/lib/display

Files:

• src/display.c (modified) (2 diffs)
• test/display.c (modified) (1 diff)

uspace/lib/display/src/display.c

@@ -198 +198 @@
 /** Destroy display window.
  *
- * @param window Window
+ * @param window Window or @c NULL
  * @return EOK on success or an error code. In both cases @a window must
  *         not be accessed anymore
@@ -206 +206 @@
         async_exch_t *exch;
         errno_t rc;
+
+        if (window == NULL)
+                return EOK;
 
         exch = async_exchange_begin(window->display->sess);

uspace/lib/display/test/display.c

@@ -331 +331 @@
 }
 
+/** display_window_destroy() can handle NULL argument */
+PCUT_TEST(window_destroy_null)
+{
+        display_window_destroy(NULL);
+}
+
 /** display_window_move_req() with server returning error response works. */
 PCUT_TEST(window_move_req_failure)