Changeset f6cf76f in mainline for kernel/arch/mips32

Timestamp:

2019-04-05T18:30:19Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

29beac8

Parents:

f4bb404

Message:

Move PIC spurious IRQ handling into arch code

As each architecture or even machine does IRQs differently, the genarch
i8259 driver cannot register the PIC spurious IRQ interrupt itself.

Location:

kernel/arch/mips32

Files:

• include/arch/mach/malta/malta.h (modified) (1 diff)
• src/mach/malta/malta.c (modified) (1 diff)

kernel/arch/mips32/include/arch/mach/malta/malta.h

@@ -45 +45 @@
 
 #define PIC0_BASE               (MALTA_PCI_BASE + 0x20)
+#define PIC0_SPURIOUS_IRQ       7
 #define PIC1_BASE               (MALTA_PCI_BASE + 0xa0)
+#define PIC1_SPURIOUS_IRQ       15
 
 #define ISA_IRQ_COUNT           16

kernel/arch/mips32/src/mach/malta/malta.c

@@ -74 +74 @@
 {
         uint8_t isa_irq = host2uint32_t_le(pio_read_32(GT64120_PCI0_INTACK));
+        if (isa_irq == PIC0_SPURIOUS_IRQ || isa_irq == PIC1_SPURIOUS_IRQ) {
+                /*
+                 * XXX: Examine ISR to figure out whether this is indeed a
+                 *      spurious or actual IRQ.
+                 */
+#ifdef CONFIG_DEBUG
+                log(LF_ARCH, LVL_DEBUG, "cpu%u: PIC spurious interrupt",
+                    CPU->id);
+                return;
+#endif
+        }
         irq_t *irq = irq_dispatch_and_lock(isa_irq);
         if (irq) {