Changeset f651e80 in mainline for kernel/arch/ia64/src

Timestamp:

2009-01-08T12:07:38Z (17 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7447572

Parents:

c571f42

Message:

Make newlines in panic messages consistent. Add periods at end of messages so that it is obvious whether they are printed entirely.

Location:

kernel/arch/ia64/src

Files:

• ia64.c (modified) (2 diffs)
• interrupt.c (modified) (4 diffs)
• mm/tlb.c (modified) (8 diffs)

kernel/arch/ia64/src/ia64.c

@@ -180 +180 @@
         t = thread_create(kkbdpoll, NULL, TASK, 0, "kkbdpoll", true);
         if (!t)
-                panic("cannot create kkbdpoll\n");
+                panic("Cannot create kkbdpoll.");
         thread_ready(t);
 #endif          
@@ -195 +195 @@
         t = thread_create(i8042_kkbdpoll, NULL, TASK, 0, "kkbdpoll", true);
         if (!t)
-                panic("cannot create kkbdpoll\n");
+                panic("Cannot create kkbdpoll.");
         thread_ready(t);
 #endif

kernel/arch/ia64/src/interrupt.c

@@ -187 +187 @@
         }
 
-        fault_if_from_uspace(istate, "General Exception (%s)", desc);
+        fault_if_from_uspace(istate, "General Exception (%s).", desc);
 
         dump_interrupted_context(istate);
-        panic("General Exception (%s)\n", desc);
+        panic("General Exception (%s).", desc);
 }
 
@@ -198 +198 @@
         scheduler_fpu_lazy_request();   
 #else
-        fault_if_from_uspace(istate, "Interruption: %#hx (%s)",
+        fault_if_from_uspace(istate, "Interruption: %#hx (%s).",
             (uint16_t) vector, vector_to_string(vector));
         dump_interrupted_context(istate);
-        panic("Interruption: %#hx (%s)\n", (uint16_t) vector,
+        panic("Interruption: %#hx (%s).", (uint16_t) vector,
             vector_to_string(vector));
 #endif
@@ -229 +229 @@
 void universal_handler(uint64_t vector, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Interruption: %#hx (%s)",
+        fault_if_from_uspace(istate, "Interruption: %#hx (%s).",
             (uint16_t) vector, vector_to_string(vector));
         dump_interrupted_context(istate);
-        panic("Interruption: %#hx (%s)\n", (uint16_t) vector,
+        panic("Interruption: %#hx (%s).", (uint16_t) vector,
             vector_to_string(vector));
 }
@@ -270 +270 @@
                         spinlock_unlock(&irq->lock);
                 } else {
-                        panic("\nUnhandled Internal Timer Interrupt (%d)\n",
+                        panic("Unhandled Internal Timer Interrupt (%d).",
                             ivr.vector);
                 }

kernel/arch/ia64/src/mm/tlb.c

@@ -473 +473 @@
                 page_table_unlock(AS, true);
                 if (as_page_fault(va, PF_ACCESS_EXEC, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate,"Page fault at %p",va);
-                        panic("%s: va=%p, rid=%d, iip=%p\n", __func__, va, rid,
+                        fault_if_from_uspace(istate,"Page fault at %p.",va);
+                        panic("%s: va=%p, rid=%d, iip=%p.", __func__, va, rid,
                             istate->cr_iip);
                 }
@@ -532 +532 @@
                         } else {
                                 fault_if_from_uspace(istate,
-                                    "IO access fault at %p", va);
+                                    "IO access fault at %p.", va);
                         }
                 }
@@ -584 +584 @@
                  */
                 if (as_page_fault(va, PF_ACCESS_READ, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate,"Page fault at %p",va);
-                        panic("%s: va=%p, rid=%d, iip=%p\n", __func__, va, rid,
+                        fault_if_from_uspace(istate,"Page fault at %p.",va);
+                        panic("%s: va=%p, rid=%d, iip=%p.", __func__, va, rid,
                             istate->cr_iip);
                 }
@@ -600 +600 @@
 void data_nested_tlb_fault(uint64_t vector, istate_t *istate)
 {
-        panic("%s\n", __func__);
+        panic("%s.", __func__);
 }
 
@@ -631 +631 @@
         } else {
                 if (as_page_fault(va, PF_ACCESS_WRITE, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate,"Page fault at %p",va);
-                        panic("%s: va=%p, rid=%d, iip=%p\n", __func__, va, rid,
+                        fault_if_from_uspace(istate,"Page fault at %p.",va);
+                        panic("%s: va=%p, rid=%d, iip=%p.", __func__, va, rid,
                             istate->cr_iip);
                 }
@@ -667 +667 @@
         } else {
                 if (as_page_fault(va, PF_ACCESS_EXEC, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate, "Page fault at %p", va);
-                        panic("%s: va=%p, rid=%d, iip=%p\n", __func__, va, rid,
+                        fault_if_from_uspace(istate, "Page fault at %p.", va);
+                        panic("%s: va=%p, rid=%d, iip=%p.", __func__, va, rid,
                             istate->cr_iip);
                 }
@@ -703 +703 @@
         } else {
                 if (as_page_fault(va, PF_ACCESS_READ, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate, "Page fault at %p", va);
-                        panic("%s: va=%p, rid=%d, iip=%p\n", __func__, va, rid,
+                        fault_if_from_uspace(istate, "Page fault at %p.", va);
+                        panic("%s: va=%p, rid=%d, iip=%p.", __func__, va, rid,
                             istate->cr_iip);
                 }
@@ -744 +744 @@
                 page_table_unlock(AS, true);
                 if (as_page_fault(va, PF_ACCESS_READ, istate) == AS_PF_FAULT) {
-                        fault_if_from_uspace(istate, "Page fault at %p", va);
-                        panic("%s: va=%p, rid=%d\n", __func__, va, rid);
+                        fault_if_from_uspace(istate, "Page fault at %p.", va);
+                        panic("%s: va=%p, rid=%d.", __func__, va, rid);
                 }
         }