Changeset f651e80 in mainline for kernel/arch/ia32xen

Timestamp:

2009-01-08T12:07:38Z (17 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7447572

Parents:

c571f42

Message:

Make newlines in panic messages consistent. Add periods at end of messages so that it is obvious whether they are printed entirely.

Location:

kernel/arch/ia32xen/src

Files:

• interrupt.c (modified) (7 diffs)
• mm/page.c (modified) (2 diffs)
• pm.c (modified) (1 diff)
• smp/smp.c (modified) (2 diffs)

kernel/arch/ia32xen/src/interrupt.c

@@ -89 +89 @@
                 eoi_function();
         else
-                panic("no eoi_function\n");
+                panic("No eoi_function.");
 
 }
@@ -95 +95 @@
 static void null_interrupt(int n, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Unserviced interrupt: %d", n);
-
-        decode_istate(istate);
-        panic("Unserviced interrupt: %d\n", n);
+        fault_if_from_uspace(istate, "Unserviced interrupt: %d.", n);
+
+        decode_istate(istate);
+        panic("Unserviced interrupt: %d.", n);
 }
 
@@ -122 +122 @@
                         return;
                 }
-                fault_if_from_uspace(istate, "General protection fault");
+                fault_if_from_uspace(istate, "General protection fault.");
         }
 
         decode_istate(istate);
-        panic("General protection fault\n");
+        panic("General protection fault.");
 }
 
 static void ss_fault(int n, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Stack fault");
-
-        decode_istate(istate);
-        panic("Stack fault\n");
+        fault_if_from_uspace(istate, "Stack fault.");
+
+        decode_istate(istate);
+        panic("Stack fault.");
 }
 
@@ -145 +145 @@
                 :"=m"(mxcsr)
         );
-        fault_if_from_uspace(istate, "SIMD FP exception(19), MXCSR: %#zx",
+        fault_if_from_uspace(istate, "SIMD FP exception(19), MXCSR: %#zx.",
                              (unative_t)mxcsr);
 
         decode_istate(istate);
         printf("MXCSR: %#zx\n",(unative_t)(mxcsr));
-        panic("SIMD FP exception(19)\n");
+        panic("SIMD FP exception(19).");
 }
 
@@ -158 +158 @@
         scheduler_fpu_lazy_request();
 #else
-        fault_if_from_uspace(istate, "FPU fault");
-        panic("FPU fault");
+        fault_if_from_uspace(istate, "FPU fault.");
+        panic("FPU fault.");
 #endif
 }
@@ -234 +234 @@
                 enable_irqs_function(irqmask);
         else
-                panic("no enable_irqs_function\n");
+                panic("No enable_irqs_function.");
 }
 
@@ -242 +242 @@
                 disable_irqs_function(irqmask);
         else
-                panic("no disable_irqs_function\n");
+                panic("No disable_irqs_function.");
 }
 

kernel/arch/ia32xen/src/mm/page.c

@@ -67 +67 @@
         
         if (istate->error_word & PFERR_CODE_RSVD)
-                panic("Reserved bit set in page directory.\n");
+                panic("Reserved bit set in page directory.");
         
         if (istate->error_word & PFERR_CODE_RW)
@@ -75 +75 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %#x", page);
+                fault_if_from_uspace(istate, "Page fault: %#x.", page);
                 
                 decode_istate(istate);
-                printf("Page fault address: %#x\n", page);
-                panic("Page fault\n");
+                printf("Page fault address: %#x.\n", page);
+                panic("Page fault.");
         }
 }

kernel/arch/ia32xen/src/pm.c

@@ -169 +169 @@
                 tss_p = (tss_t *) malloc(sizeof(tss_t), FRAME_ATOMIC);
                 if (!tss_p)
-                        panic("could not allocate TSS\n");
+                        panic("Cannot allocate TSS.");
         }
 

kernel/arch/ia32xen/src/smp/smp.c

@@ -73 +73 @@
         l_apic_address = (uintptr_t) frame_alloc(ONE_FRAME, FRAME_ATOMIC | FRAME_KA);
         if (!l_apic_address)
-                panic("cannot allocate address for l_apic\n");
+                panic("Cannot allocate address for l_apic.");
 
         io_apic_address = (uintptr_t) frame_alloc(ONE_FRAME, FRAME_ATOMIC | FRAME_KA);
         if (!io_apic_address)
-                panic("cannot allocate address for io_apic\n");
+                panic("Cannot allocate address for io_apic.");
 
         if (config.cpu_count > 1) {             
@@ -144 +144 @@
                  */
                 if (!(gdt_new = (struct descriptor *) malloc(GDT_ITEMS * sizeof(struct descriptor), FRAME_ATOMIC)))
-                        panic("couldn't allocate memory for GDT\n");
+                        panic("Cannot allocate memory for GDT.");
 
                 memcpy(gdt_new, gdt, GDT_ITEMS * sizeof(struct descriptor));