Changeset f651e80 in mainline for kernel/arch/ia32/src

Timestamp:

2009-01-08T12:07:38Z (17 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7447572

Parents:

c571f42

Message:

Make newlines in panic messages consistent. Add periods at end of messages so that it is obvious whether they are printed entirely.

Location:

kernel/arch/ia32/src

Files:

• drivers/vesa.c (modified) (1 diff)
• interrupt.c (modified) (7 diffs)
• mm/page.c (modified) (3 diffs)
• pm.c (modified) (1 diff)
• smp/smp.c (modified) (2 diffs)

kernel/arch/ia32/src/drivers/vesa.c

@@ -84 +84 @@
                 break;
         default:
-                panic("Unsupported bits per pixel");
+                panic("Unsupported bits per pixel.");
         }
         

kernel/arch/ia32/src/interrupt.c

@@ -90 +90 @@
                 eoi_function();
         else
-                panic("no eoi_function\n");
+                panic("No eoi_function.");
 
 }
@@ -96 +96 @@
 static void null_interrupt(int n, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Unserviced interrupt: %d", n);
-
-        decode_istate(istate);
-        panic("Unserviced interrupt: %d\n", n);
+        fault_if_from_uspace(istate, "Unserviced interrupt: %d.", n);
+
+        decode_istate(istate);
+        panic("Unserviced interrupt: %d.", n);
 }
 
@@ -123 +123 @@
                         return;
                 }
-                fault_if_from_uspace(istate, "General protection fault");
+                fault_if_from_uspace(istate, "General protection fault.");
         }
 
         decode_istate(istate);
-        panic("General protection fault\n");
+        panic("General protection fault.");
 }
 
 static void ss_fault(int n __attribute__((unused)), istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Stack fault");
-
-        decode_istate(istate);
-        panic("Stack fault\n");
+        fault_if_from_uspace(istate, "Stack fault.");
+
+        decode_istate(istate);
+        panic("Stack fault.");
 }
 
@@ -145 +145 @@
                 : "=m" (mxcsr)
         );
-        fault_if_from_uspace(istate, "SIMD FP exception(19), MXCSR: %#zx",
+        fault_if_from_uspace(istate, "SIMD FP exception(19), MXCSR: %#zx.",
             (unative_t) mxcsr);
 
         decode_istate(istate);
         printf("MXCSR: %#lx\n", mxcsr);
-        panic("SIMD FP exception(19)\n");
+        panic("SIMD FP exception(19).");
 }
 
@@ -158 +158 @@
         scheduler_fpu_lazy_request();
 #else
-        fault_if_from_uspace(istate, "FPU fault");
-        panic("FPU fault");
+        fault_if_from_uspace(istate, "FPU fault.");
+        panic("FPU fault.");
 #endif
 }
@@ -234 +234 @@
                 enable_irqs_function(irqmask);
         else
-                panic("no enable_irqs_function\n");
+                panic("No enable_irqs_function.");
 }
 
@@ -242 +242 @@
                 disable_irqs_function(irqmask);
         else
-                panic("no disable_irqs_function\n");
+                panic("No disable_irqs_function.");
 }
 

kernel/arch/ia32/src/mm/page.c

@@ -80 +80 @@
 {
         if (last_frame + ALIGN_UP(size, PAGE_SIZE) > KA2PA(KERNEL_ADDRESS_SPACE_END_ARCH))
-                panic("Unable to map physical memory %p (%d bytes)", physaddr, size)
+                panic("Unable to map physical memory %p (%d bytes).", physaddr, size)
         
         uintptr_t virtaddr = PA2KA(last_frame);
@@ -102 +102 @@
                 
         if (istate->error_word & PFERR_CODE_RSVD)
-                panic("Reserved bit set in page directory.\n");
+                panic("Reserved bit set in page directory.");
 
         if (istate->error_word & PFERR_CODE_RW)
@@ -110 +110 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %#x", page);
+                fault_if_from_uspace(istate, "Page fault: %#x.", page);
                 
                 decode_istate(istate);
                 printf("page fault address: %#lx\n", page);
-                panic("page fault\n");
+                panic("Page fault.");
         }
 }

kernel/arch/ia32/src/pm.c

@@ -199 +199 @@
                 tss_p = (tss_t *) malloc(sizeof(tss_t), FRAME_ATOMIC);
                 if (!tss_p)
-                        panic("could not allocate TSS\n");
+                        panic("Cannot allocate TSS.");
         }
 

kernel/arch/ia32/src/smp/smp.c

@@ -76 +76 @@
             FRAME_ATOMIC | FRAME_KA);
         if (!l_apic_address)
-                panic("cannot allocate address for l_apic\n");
+                panic("Cannot allocate address for l_apic.");
 
         io_apic_address = (uintptr_t) frame_alloc(ONE_FRAME,
             FRAME_ATOMIC | FRAME_KA);
         if (!io_apic_address)
-                panic("cannot allocate address for io_apic\n");
+                panic("Cannot allocate address for io_apic.");
 
         if (config.cpu_count > 1) {             
@@ -158 +158 @@
                     sizeof(struct descriptor), FRAME_ATOMIC | FRAME_LOW_4_GiB);
                 if (!gdt_new)
-                        panic("couldn't allocate memory for GDT\n");
+                        panic("Cannot allocate memory for GDT.");
 
                 memcpy(gdt_new, gdt, GDT_ITEMS * sizeof(struct descriptor));