Changeset f651e80 in mainline for kernel/arch/amd64/src

Timestamp:

2009-01-08T12:07:38Z (17 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7447572

Parents:

c571f42

Message:

Make newlines in panic messages consistent. Add periods at end of messages so that it is obvious whether they are printed entirely.

Location:

kernel/arch/amd64/src

Files:

• interrupt.c (modified) (6 diffs)
• mm/page.c (modified) (3 diffs)
• pm.c (modified) (1 diff)

kernel/arch/amd64/src/interrupt.c

@@ -95 +95 @@
                 eoi_function();
         else
-                panic("no eoi_function\n");
+                panic("No eoi_function.");
 
 }
@@ -101 +101 @@
 static void null_interrupt(int n, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Unserviced interrupt: %d", n);
+        fault_if_from_uspace(istate, "Unserviced interrupt: %d.", n);
         decode_istate(n, istate);
-        panic("Unserviced interrupt\n");
+        panic("Unserviced interrupt.");
 }
 
@@ -127 +127 @@
                         return;
                 }
-                fault_if_from_uspace(istate, "General protection fault");
+                fault_if_from_uspace(istate, "General protection fault.");
         }
 
         decode_istate(n, istate);
-        panic("General protection fault\n");
+        panic("General protection fault.");
 }
 
 static void ss_fault(int n, istate_t *istate)
 {
-        fault_if_from_uspace(istate, "Stack fault");
+        fault_if_from_uspace(istate, "Stack fault.");
         decode_istate(n, istate);
-        panic("Stack fault\n");
+        panic("Stack fault.");
 }
 
@@ -146 +146 @@
         scheduler_fpu_lazy_request();
 #else
-        fault_if_from_uspace(istate, "FPU fault");
-        panic("FPU fault");
+        fault_if_from_uspace(istate, "FPU fault.");
+        panic("FPU fault.");
 #endif
 }
@@ -222 +222 @@
                 enable_irqs_function(irqmask);
         else
-                panic("no enable_irqs_function\n");
+                panic("No enable_irqs_function.");
 }
 
@@ -230 +230 @@
                 disable_irqs_function(irqmask);
         else
-                panic("no disable_irqs_function\n");
+                panic("No disable_irqs_function.");
 }
 

kernel/arch/amd64/src/mm/page.c

@@ -181 +181 @@
         
         if (istate->error_word & PFERR_CODE_RSVD)
-                panic("Reserved bit set in page table entry.\n");
+                panic("Reserved bit set in page table entry.");
         
         if (istate->error_word & PFERR_CODE_RW)
@@ -191 +191 @@
         
         if (as_page_fault(page, access, istate) == AS_PF_FAULT) {
-                fault_if_from_uspace(istate, "Page fault: %#x", page);
+                fault_if_from_uspace(istate, "Page fault: %#x.", page);
 
                 decode_istate(n, istate);
-                printf("Page fault address: %llx\n", page);
-                panic("Page fault\n");
+                printf("Page fault address: %llx.\n", page);
+                panic("Page fault.");
         }
 }
@@ -203 +203 @@
 {
         if (last_frame + ALIGN_UP(size, PAGE_SIZE) > KA2PA(KERNEL_ADDRESS_SPACE_END_ARCH))
-                panic("Unable to map physical memory %p (%d bytes)", physaddr, size)
+                panic("Unable to map physical memory %p (%d bytes).", physaddr, size)
         
         uintptr_t virtaddr = PA2KA(last_frame);

kernel/arch/amd64/src/pm.c

@@ -210 +210 @@
                 tss_p = (struct tss *) malloc(sizeof(tss_t), FRAME_ATOMIC);
                 if (!tss_p)
-                        panic("could not allocate TSS\n");
+                        panic("Cannot allocate TSS.");
         }