Changeset eb13ef8 in mainline for uspace/drv/hid

Timestamp:

2019-02-06T13:25:12Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fafb8e5

Parents:

bb97118

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-02 14:04:02)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-06 13:25:12)

Message:

Change IPC_GET_* and IPC_SET_* to accept pointer instead of lvalue

Location:

uspace/drv/hid

Files:

• adb-kbd/adb-kbd.c (modified) (2 diffs)
• adb-mouse/adb-mouse.c (modified) (2 diffs)
• atkbd/atkbd.c (modified) (1 diff)
• ps2mouse/ps2mouse.c (modified) (1 diff)
• usbhid/kbd/kbddev.c (modified) (2 diffs)
• xtkbd/xtkbd.c (modified) (2 diffs)

uspace/drv/hid/adb-kbd/adb-kbd.c

@@ -141 +141 @@
                 errno_t retval = EOK;
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         async_answer_0(&call, EOK);
                         return;
                 }
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case ADB_REG_NOTIF:
-                        adb_kbd_reg0_data(kbd, IPC_GET_ARG1(call));
+                        adb_kbd_reg0_data(kbd, IPC_GET_ARG1(&call));
                         break;
                 default:
@@ -205 +205 @@
         while (true) {
                 async_get_call(&call);
-                method = IPC_GET_IMETHOD(call);
+                method = IPC_GET_IMETHOD(&call);
 
                 if (!method) {

uspace/drv/hid/adb-mouse/adb-mouse.c

@@ -99 +99 @@
                 errno_t retval = EOK;
 
-                if (!IPC_GET_IMETHOD(call)) {
+                if (!IPC_GET_IMETHOD(&call)) {
                         /* TODO: Handle hangup */
                         return;
                 }
 
-                switch (IPC_GET_IMETHOD(call)) {
+                switch (IPC_GET_IMETHOD(&call)) {
                 case ADB_REG_NOTIF:
-                        adb_mouse_data(mouse, IPC_GET_ARG1(call));
+                        adb_mouse_data(mouse, IPC_GET_ARG1(&call));
                         break;
                 default:
@@ -215 +215 @@
         while (true) {
                 async_get_call(&call);
-                method = IPC_GET_IMETHOD(call);
+                method = IPC_GET_IMETHOD(&call);
 
                 if (!method) {

uspace/drv/hid/atkbd/atkbd.c

@@ -310 +310 @@
 static void default_connection_handler(ddf_fun_t *fun, ipc_call_t *icall)
 {
-        const sysarg_t method = IPC_GET_IMETHOD(*icall);
+        const sysarg_t method = IPC_GET_IMETHOD(icall);
         at_kbd_t *kbd = ddf_dev_data_get(ddf_fun_get_dev(fun));
         async_sess_t *sess;

uspace/drv/hid/ps2mouse/ps2mouse.c

@@ -429 +429 @@
 void default_connection_handler(ddf_fun_t *fun, ipc_call_t *icall)
 {
-        const sysarg_t method = IPC_GET_IMETHOD(*icall);
+        const sysarg_t method = IPC_GET_IMETHOD(icall);
         ps2_mouse_t *mouse = ddf_dev_data_get(ddf_fun_get_dev(fun));
         async_sess_t *sess;

uspace/drv/hid/usbhid/kbd/kbddev.c

@@ -159 +159 @@
 static void default_connection_handler(ddf_fun_t *fun, ipc_call_t *icall)
 {
-        const sysarg_t method = IPC_GET_IMETHOD(*icall);
+        const sysarg_t method = IPC_GET_IMETHOD(icall);
         usb_kbd_t *kbd_dev = ddf_fun_data_get(fun);
         async_sess_t *sess;
@@ -165 +165 @@
         switch (method) {
         case KBDEV_SET_IND:
-                kbd_dev->mods = IPC_GET_ARG1(*icall);
+                kbd_dev->mods = IPC_GET_ARG1(icall);
                 usb_kbd_set_led(kbd_dev->hid_dev, kbd_dev);
                 async_answer_0(icall, EOK);

uspace/drv/hid/xtkbd/xtkbd.c

@@ -344 +344 @@
 static void default_connection_handler(ddf_fun_t *fun, ipc_call_t *icall)
 {
-        const sysarg_t method = IPC_GET_IMETHOD(*icall);
+        const sysarg_t method = IPC_GET_IMETHOD(icall);
         xt_kbd_t *kbd = ddf_dev_data_get(ddf_fun_get_dev(fun));
         unsigned mods;
@@ -355 +355 @@
                  * assume AT keyboard with Scan Code Set 1.
                  */
-                mods = IPC_GET_ARG1(*icall);
+                mods = IPC_GET_ARG1(icall);
                 const uint8_t status = 0 |
                     ((mods & KM_CAPS_LOCK) ? LI_CAPS : 0) |