Changeset e9bc927 in mainline for kernel/genarch/src

Timestamp:

2025-04-18T08:22:19Z (3 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

25fdb2d

Parents:

51949d0

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-18 07:18:03)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-18 08:22:19)

Message:

Update forgotten serial implementations

Location:

kernel/genarch/src/drivers

Files:

• dsrln/dsrlnout.c (modified) (1 diff)
• omap/uart.c (modified) (1 diff)
• s3c24xx/uart.c (modified) (3 diffs)

kernel/genarch/src/drivers/dsrln/dsrlnout.c

@@ -49 +49 @@
 } dsrlnout_instance_t;
 
-static void dsrlnout_putuchar(outdev_t *dev, const char32_t ch)
+static void dsrlnout_write(outdev_t *dev, const char *s, size_t n)
 {
         dsrlnout_instance_t *instance = (dsrlnout_instance_t *) dev->data;
 
-        if ((!instance->parea.mapped) || (console_override)) {
-                if (ascii_check(ch))
-                        pio_write_8(instance->base, ch);
-                else
-                        pio_write_8(instance->base, U_SPECIAL);
+        if (instance->parea.mapped && !console_override)
+                return;
+
+        const char *top = s + n;
+        assert(top >= s);
+
+        for (; s < top; s++) {
+                if (*s == '\n')
+                        pio_write_8(instance->base, '\r');
+
+                pio_write_8(instance->base, (uint8_t) *s);
         }
 }
 
 static outdev_operations_t dsrlndev_ops = {
-        .write = dsrlnout_putuchar,
+        .write = dsrlnout_write,
         .redraw = NULL,
         .scroll_up = NULL,

kernel/genarch/src/drivers/omap/uart.c

@@ -49 +49 @@
 }
 
-static void omap_uart_putuchar(outdev_t *dev, char32_t ch)
+static void omap_uart_write(outdev_t *dev, const char *s, size_t n)
 {
         omap_uart_t *uart = dev->data;
-        if (!ascii_check(ch)) {
-                omap_uart_txb(uart, U_SPECIAL);
-        } else {
-                if (ch == '\n')
+
+        const char *top = s + n;
+        assert(top >= s);
+
+        for (; s < top; s++) {
+                if (*s == '\n')
                         omap_uart_txb(uart, '\r');
-                omap_uart_txb(uart, ch);
+
+                omap_uart_txb(uart, (uint8_t) *s);
         }
 }
 
 static outdev_operations_t omap_uart_ops = {
-        .write = omap_uart_putuchar,
+        .write = omap_uart_write,
         .redraw = NULL,
         .scroll_up = NULL,

kernel/genarch/src/drivers/s3c24xx/uart.c

@@ -49 +49 @@
 #include <str.h>
 
-static void s3c24xx_uart_sendb(outdev_t *dev, uint8_t byte)
+static void s3c24xx_uart_sendb(s3c24xx_uart_t *uart, uint8_t byte)
 {
-        s3c24xx_uart_t *uart =
-            (s3c24xx_uart_t *) dev->data;
-
         /* Wait for space becoming available in Tx FIFO. */
         while ((pio_read_32(&uart->io->ufstat) & S3C24XX_UFSTAT_TX_FULL) != 0)
@@ -61 +58 @@
 }
 
-static void s3c24xx_uart_putuchar(outdev_t *dev, char32_t ch)
+static void s3c24xx_uart_write(outdev_t *dev, const char *s, size_t n)
 {
-        s3c24xx_uart_t *uart =
-            (s3c24xx_uart_t *) dev->data;
+        s3c24xx_uart_t *uart = dev->data;
 
-        if ((!uart->parea.mapped) || (console_override)) {
-                if (!ascii_check(ch)) {
-                        s3c24xx_uart_sendb(dev, U_SPECIAL);
-                } else {
-                        if (ch == '\n')
-                                s3c24xx_uart_sendb(dev, (uint8_t) '\r');
-                        s3c24xx_uart_sendb(dev, (uint8_t) ch);
-                }
+        /* If the userspace owns the console, do not output anything. */
+        if (uart->parea.mapped && !console_override)
+                return;
+
+        const char *top = s + n;
+        assert(top >= s);
+
+        for (; s < top; s++) {
+                if (*s == '\n')
+                        s3c24xx_uart_sendb(uart, '\r');
+
+                s3c24xx_uart_sendb(uart, (uint8_t) *s);
         }
 }
@@ -94 +94 @@
 
 static outdev_operations_t s3c24xx_uart_ops = {
-        .write = s3c24xx_uart_putuchar,
+        .write = s3c24xx_uart_write,
         .redraw = NULL,
         .scroll_up = NULL,