Changeset dfa4be62 in mainline for kernel/generic/src/proc/scheduler.c

Timestamp:

2024-01-21T16:23:19Z (18 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

d23712e

Parents:

a3d87b9

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-03-28 17:40:43)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-21 16:23:19)

Message:

Thread lock is no longer necessary

File:

• kernel/generic/src/proc/scheduler.c (modified) (11 diffs)

kernel/generic/src/proc/scheduler.c

@@ -310 +310 @@
         switch_task(THREAD->task);
 
-        irq_spinlock_lock(&THREAD->lock, false);
         assert(atomic_get_unordered(&THREAD->cpu) == CPU);
 
@@ -364 +363 @@
         /* Save current CPU cycle */
         THREAD->last_cycle = get_cycle();
-
-        irq_spinlock_unlock(&THREAD->lock, false);
 }
 
@@ -386 +383 @@
 static void thread_requeue_preempted(thread_t *thread)
 {
-        irq_spinlock_lock(&thread->lock, false);
-
         assert(atomic_get_unordered(&thread->state) == Running);
         assert(atomic_get_unordered(&thread->cpu) == CPU);
@@ -400 +395 @@
         atomic_set_unordered(&thread->state, Ready);
 
-        irq_spinlock_unlock(&thread->lock, false);
-
         add_to_rq(thread, CPU, prio);
 }
@@ -408 +401 @@
 {
         ipl_t ipl = interrupts_disable();
-
-        irq_spinlock_lock(&thread->lock, false);
 
         assert(atomic_get_unordered(&thread->state) == Sleeping || atomic_get_unordered(&thread->state) == Entering);
@@ -423 +414 @@
                 atomic_set_unordered(&thread->cpu, CPU);
         }
-
-        irq_spinlock_unlock(&thread->lock, false);
 
         add_to_rq(thread, cpu, 0);
@@ -500 +489 @@
         }
 
-        irq_spinlock_lock(&THREAD->lock, false);
-
         atomic_set_unordered(&THREAD->state, new_state);
 
@@ -514 +501 @@
          */
         after_thread_ran_arch();
-
-        irq_spinlock_unlock(&THREAD->lock, false);
 
         CPU_LOCAL->exiting_state = new_state;
@@ -650 +635 @@
         list_foreach_rev(old_rq->rq, rq_link, thread_t, thread) {
 
-                irq_spinlock_lock(&thread->lock, false);
-
                 /*
                  * Do not steal CPU-wired threads, threads
@@ -658 +641 @@
                  * FPU context is still in the CPU.
                  */
-                if (thread->stolen || thread->nomigrate ||
-                    thread == fpu_owner) {
-                        irq_spinlock_unlock(&thread->lock, false);
+                if (thread->stolen || thread->nomigrate || thread == fpu_owner) {
                         continue;
                 }
@@ -666 +647 @@
                 thread->stolen = true;
                 atomic_set_unordered(&thread->cpu, CPU);
-
-                irq_spinlock_unlock(&thread->lock, false);
 
                 /*