Changeset dcdb990 in mainline

Timestamp:

2025-06-30T17:14:01Z (3 weeks ago)

Author:

Miroslav Cimerman <mc@…>

Children:

996d31ac

Parents:

d04a350

Message:

hr: metadata/md: have to take rebuild into account

Even if not allowing rebuild operation to happen,
we still must take rebuilt extents into account,
because writes below the resync_offset must be
done like in ONLINE state.

File:

• uspace/srv/bd/hr/metadata/foreign/md/hr_md.c (modified) (4 diffs)

uspace/srv/bd/hr/metadata/foreign/md/hr_md.c

@@ -194 +194 @@
                 return ENOMEM;
 
+        bool rebuild_set = false;
         size_t i = 0;
         list_foreach(*list, link, struct dev_list_member, iter) {
@@ -208 +209 @@
 
                 bool invalidate = false;
+                bool rebuild_this_ext = false;
 
                 if (iter_meta->events != max_events)
                         invalidate = true;
 
-                if (iter_meta->feature_map & MD_DISK_SYNC)
-                        invalidate = true;
-
-                if (!invalidate)
+                if (iter_meta->feature_map & MD_DISK_SYNC && !invalidate) {
+                        if (rebuild_set) {
+                                HR_DEBUG("only 1 rebuilt extent allowed");
+                                rc = EINVAL;
+                                goto error;
+                        }
+                        rebuild_set = true;
+                        rebuild_this_ext = true;
+                        vol->rebuild_blk = iter_meta->resync_offset;
+                }
+
+                if (!rebuild_this_ext && !invalidate)
                         vol->extents[index].state = HR_EXT_ONLINE;
+                else if (rebuild_this_ext && !invalidate)
+                        vol->extents[index].state = HR_EXT_REBUILD;
                 else
                         vol->extents[index].state = HR_EXT_INVALID;
@@ -230 +242 @@
         }
 
+error:
         return rc;
 }
@@ -506 +519 @@
 
         md->feature_map = uint32_t_le2host(md->feature_map);
-        /* XXX: do not even support MD_DISK_SYNC here */
-        if (md->feature_map != 0x0) {
+        if (md->feature_map != 0x0 && md->feature_map != MD_DISK_SYNC) {
                 HR_DEBUG("unsupported feature map bits\n");
                 rc = EINVAL;