Changeset d1582b50 in mainline for uspace/lib/usbhid

Timestamp:

2020-12-14T20:41:53Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

02fe42e

Parents:

1382446

git-author:

Jiri Svoboda <jiri@…> (2020-12-14 20:33:54)

git-committer:

Jiri Svoboda <jiri@…> (2020-12-14 20:41:53)

Message:

Fix spacing in single-line comments using latest ccheck

This found incorrectly formatted section comments (with blocks of
asterisks or dashes). I strongly believe against using section comments
but I am not simply removing them since that would probably be
controversial.

Location:

uspace/lib/usbhid

Files:

• include/usb/hid/hidpath.h (modified) (1 diff)
• include/usb/hid/hidtypes.h (modified) (5 diffs)
• src/hiddescriptor.c (modified) (3 diffs)

uspace/lib/usbhid/include/usb/hid/hidpath.h

@@ -83 +83 @@
         uint32_t usage;
 
-        /** Attribute of Collection tag in report descriptor*/
+        /** Attribute of Collection tag in report descriptor */
         uint8_t flags;
 

uspace/lib/usbhid/include/usb/hid/hidtypes.h

@@ -211 +211 @@
         int usages_count;
 
-        /** Usage page*/
+        /** Usage page */
         uint32_t usage_page;
 
@@ -226 +226 @@
         int32_t logical_maximum;
 
-        /** Length of the items in bits*/
+        /** Length of the items in bits */
         int32_t size;
 
-        /** COunt of items*/
+        /** Count of items */
         int32_t count;
 
@@ -252 +252 @@
         uint32_t designator_index;
 
-        /** Minimum valid designator value*/
+        /** Minimum valid designator value */
         uint32_t designator_minimum;
 
-        /** Maximum valid designator value*/
+        /** Maximum valid designator value */
         uint32_t designator_maximum;
 
-        /** Minimal valid physical value*/
+        /** Minimal valid physical value */
         int32_t physical_minimum;
 
@@ -264 +264 @@
         int32_t physical_maximum;
 
-        /** Items attributes*/
+        /** Items attributes */
         uint8_t item_flags;
 
@@ -270 +270 @@
         usb_hid_report_type_t type;
 
-        /** current collection path*/
+        /** current collection path */
         usb_hid_report_path_t *usage_path;
 
-        /** Unused*/
+        /** Unused */
         link_t link;
 

uspace/lib/usbhid/src/hiddescriptor.c

@@ -74 +74 @@
 
 #define USB_HID_INVALID                 -98
-/** Unknown tag was founded in report descriptor data*/
+/** Unknown tag was founded in report descriptor data */
 #define USB_HID_UNKNOWN_TAG             -99
 
@@ -245 +245 @@
                 field->item_flags = report_item->item_flags;
 
-                /* find the right report list*/
+                /* find the right report list */
                 usb_hid_report_description_t *report_des;
                 report_des = usb_hid_report_find_description(report,
@@ -352 +352 @@
         list_initialize(&stack);
 
-        /* parser structure initialization*/
+        /* parser structure initialization */
         if (usb_hid_report_init(report) != EOK) {
                 return EINVAL;
         }
 
-        /*report item initialization*/
+        /* report item initialization */
         if (!(report_item = malloc(sizeof(usb_hid_report_item_t)))) {
                 return ENOMEM;