Changeset d0dd7b5 in mainline for uspace/srv/devman

Timestamp:

2011-08-18T20:10:47Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ef7052ec

Parents:

763e0cd

Message:

Work on device removal:

• properly track service memberships in categories
• implement loc_service_unregister()
• ddf_fun_unbind() (limited to exposed functions for now)

Location:

uspace/srv/devman

Files:

• devman.c (modified) (1 diff)
• devman.h (modified) (3 diffs)
• main.c (modified) (3 diffs)

uspace/srv/devman/devman.c

@@ -1100 +1100 @@
 }
 
+/** Remove function from device tree.
+ *
+ * @param tree          Device tree
+ * @param node          Function node to remove
+ */
+void remove_fun_node(dev_tree_t *tree, fun_node_t *fun)
+{
+        assert(tree != NULL);
+        assert(fun != NULL);
+        assert(fibril_rwlock_is_write_locked(&tree->rwlock));
+        
+        /* Remove the node from the handle-to-node map. */
+        unsigned long key = fun->handle;
+        hash_table_remove(&tree->devman_functions, &key, 1);
+        
+        /* Remove the node from the list of its parent's children. */
+        if (fun->dev != NULL)
+                list_remove(&fun->dev_functions);
+}
+
 /** Find function node with a specified path in the device tree.
  * 

uspace/srv/devman/devman.h

@@ -1 +1 @@
 /*
  * Copyright (c) 2010 Lenka Trochtova
+ * Copyright (c) 2011 Jiri Svoboda
  * All rights reserved.
  *
@@ -154 +155 @@
         /** Name of the function, assigned by the device driver */
         char *name;
+        /** Function type */
+        fun_type_t ftype;
         
         /** Full path and name of the device in device hierarchy */
@@ -265 +268 @@
 extern bool insert_dev_node(dev_tree_t *, dev_node_t *, fun_node_t *);
 extern bool insert_fun_node(dev_tree_t *, fun_node_t *, char *, dev_node_t *);
+extern void remove_fun_node(dev_tree_t *, fun_node_t *);
 
 /* Loc services */

uspace/srv/devman/main.c

@@ -278 +278 @@
                 return;
         }
-
+        
         fun_node_t *fun = create_fun_node();
+        fun->ftype = ftype;
+        
         if (!insert_fun_node(&device_tree, fun, fun_name, pdev)) {
                 fibril_rwlock_write_unlock(&tree->rwlock);
@@ -367 +369 @@
 }
 
+/** Remove function. */
+static void devman_remove_function(ipc_callid_t callid, ipc_call_t *call)
+{
+        devman_handle_t fun_handle = IPC_GET_ARG1(*call);
+        dev_tree_t *tree = &device_tree;
+        int rc;
+        
+        fibril_rwlock_write_lock(&tree->rwlock);
+        
+        fun_node_t *fun = find_fun_node_no_lock(&device_tree, fun_handle);
+        if (fun == NULL) {
+                fibril_rwlock_write_unlock(&tree->rwlock);
+                async_answer_0(callid, ENOENT);
+                return;
+        }
+        
+        log_msg(LVL_DEBUG, "devman_remove_function(fun='%s')", fun->pathname);
+        
+        if (fun->ftype == fun_inner) {
+                /* Handle possible descendants */
+                /* TODO */
+                log_msg(LVL_WARN, "devman_remove_function(): not handling "
+                    "descendants\n");
+        } else {
+                /* Unregister from location service */
+                rc = loc_service_unregister(fun->service_id);
+                if (rc != EOK) {
+                        log_msg(LVL_ERROR, "Failed unregistering tree service.");
+                        fibril_rwlock_write_unlock(&tree->rwlock);
+                        async_answer_0(callid, EIO);
+                        return;
+                }
+        }
+        
+        remove_fun_node(&device_tree, fun);
+        fibril_rwlock_write_unlock(&tree->rwlock);
+        delete_fun_node(fun);
+        
+        log_msg(LVL_DEBUG, "devman_remove_function() succeeded.");
+        async_answer_0(callid, EOK);
+}
+
 /** Initialize driver which has registered itself as running and ready.
  *
@@ -418 +462 @@
                 case DEVMAN_ADD_DEVICE_TO_CATEGORY:
                         devman_add_function_to_cat(callid, &call);
+                        break;
+                case DEVMAN_REMOVE_FUNCTION:
+                        devman_remove_function(callid, &call);
                         break;
                 default: