Changeset cfb79747 in mainline for uspace/drv/nic/ne2k

Timestamp:

2012-02-14T22:06:15Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a31aad1

Parents:

199112e4 (diff), e10d41a (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

Location:

uspace/drv/nic/ne2k

Files:

• dp8390.c (modified) (7 diffs)
• dp8390.h (modified) (1 diff)
• ne2k.c (modified) (4 diffs)

uspace/drv/nic/ne2k/dp8390.c

@@ -59 +59 @@
 #include <stdio.h>
 #include <libarch/ddi.h>
-#include <net/packet.h>
-#include <packet_client.h>
 #include "dp8390.h"
 
@@ -76 +74 @@
         uint8_t status;
         
-        /** Pointer to next packet */
+        /** Pointer to next frame */
         uint8_t next;
         
@@ -393 +391 @@
         /*
          * Reset the transmit ring. If we were transmitting a frame,
-         * we pretend that the packet is processed. Higher layers will
-         * retransmit if the packet wasn't actually sent.
+         * we pretend that the frame is processed. Higher layers will
+         * retransmit if the frame wasn't actually sent.
          */
         ne2k->sq.dirty = false;
@@ -448 +446 @@
                 return NULL;
         
-        void *buf = packet_suffix(frame->packet, length);
-        bzero(buf, length);
+        bzero(frame->data, length);
         uint8_t last = page + length / DP_PAGE;
         
@@ -455 +452 @@
                 size_t left = (ne2k->stop_page - page) * DP_PAGE
                     - sizeof(recv_header_t);
-                ne2k_download(ne2k, buf, page * DP_PAGE + sizeof(recv_header_t),
+                ne2k_download(ne2k, frame->data, page * DP_PAGE + sizeof(recv_header_t),
                     left);
-                ne2k_download(ne2k, buf + left, ne2k->start_page * DP_PAGE,
+                ne2k_download(ne2k, frame->data + left, ne2k->start_page * DP_PAGE,
                     length - left);
         } else {
-                ne2k_download(ne2k, buf, page * DP_PAGE + sizeof(recv_header_t),
+                ne2k_download(ne2k, frame->data, page * DP_PAGE + sizeof(recv_header_t),
                     length);
         }
@@ -541 +538 @@
                  * Update the boundary pointer
                  * to the value of the page
-                 * prior to the next packet to
+                 * prior to the next frame to
                  * be processed.
                  */
@@ -584 +581 @@
                 fibril_mutex_lock(&ne2k->sq_mutex);
                 if (ne2k->sq.dirty) {
-                        /* Prepare the buffer for next packet */
+                        /* Prepare the buffer for next frame */
                         ne2k->sq.dirty = false;
                         ne2k->sq.size = 0;

uspace/drv/nic/ne2k/dp8390.h

@@ -264 +264 @@
 extern void ne2k_send(nic_t *, void *, size_t);
 extern void ne2k_interrupt(nic_t *, uint8_t, uint8_t);
-extern packet_t *ne2k_alloc_packet(nic_t *, size_t);
 
 extern void ne2k_set_accept_mcast(ne2k_t *, int);

uspace/drv/nic/ne2k/ne2k.c

@@ -286 +286 @@
         /* Note: some frame with previous physical address may slip to NIL here
          * (for a moment the filtering is not exact), but ethernet should be OK with
-         * that. Some packet may also be lost, but this is not a problem.
+         * that. Some frames may also be lost, but this is not a problem.
          */
         ne2k_set_physical_address((ne2k_t *) nic_get_specific(nic_data), address);
@@ -363 +363 @@
 static int ne2k_dev_add(ddf_dev_t *dev)
 {
+        ddf_fun_t *fun;
+        
         /* Allocate driver data for the device. */
         nic_t *nic_data = nic_create_and_bind(dev);
@@ -396 +398 @@
         }
         
-        rc = nic_register_as_ddf_fun(nic_data, &ne2k_dev_ops);
+        rc = nic_connect_to_services(nic_data);
         if (rc != EOK) {
                 ne2k_dev_cleanup(dev);
@@ -402 +404 @@
         }
         
-        rc = nic_connect_to_services(nic_data);
-        if (rc != EOK) {
+        fun = ddf_fun_create(nic_get_ddf_dev(nic_data), fun_exposed, "port0");
+        if (fun == NULL) {
                 ne2k_dev_cleanup(dev);
+                return ENOMEM;
+        }
+        nic_set_ddf_fun(nic_data, fun);
+        fun->ops = &ne2k_dev_ops;
+        fun->driver_data = nic_data;
+        
+        rc = ddf_fun_bind(fun);
+        if (rc != EOK) {
+                ddf_fun_destroy(fun);
+                ne2k_dev_cleanup(dev);
+                return rc;
+        }
+        
+        rc = ddf_fun_add_to_category(fun, DEVICE_CATEGORY_NIC);
+        if (rc != EOK) {
+                ddf_fun_unbind(fun);
+                ddf_fun_destroy(fun);
                 return rc;
         }