Changeset ca07cd3 in mainline for uspace/srv/hw/bus/usb/hcd/virtual/devices.c

Timestamp:

2010-10-25T13:23:33Z (15 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

23cb44b

Parents:

355f7c2

Message:

Code cleanup, various bugfixes

The internal functions of virtual device framework always get
device structure as parameter, thus possible enabling more devices
within single task (that is not possible because currently there
is no way to pass extra argument into callback_connection()).

Also, added some missing comments and completely removed the device
id nonsense (devices can send their descriptors and the hub is able
to enable/disable its ports).

File:

• uspace/srv/hw/bus/usb/hcd/virtual/devices.c (modified) (2 diffs)

uspace/srv/hw/bus/usb/hcd/virtual/devices.c

@@ -43 +43 @@
 #include <str_error.h>
 
-#include <usbvirt/ids.h>
 #include <usbvirt/hub.h>
 
@@ -55 +54 @@
 
 LIST_INITIALIZE(devices);
-
-/** Recognise device by id.
- *
- * @param id Device id.
- * @param phone Callback phone.
- */
-virtdev_connection_t *virtdev_recognise(int id, int phone)
-{
-        virtdev_connection_t * dev = virtdev_add_device(phone);
-        
-        /*
-         * We do not want to mess-up the virtdev_add_device() as
-         * the id is needed only before device probing/detection
-         * is implemented.
-         *
-         * However, that does not mean that this will happen soon.
-         */
-        if (dev) {
-                dev->id = id;
-        }
-        
-        return dev;
-}
 
 /** Create virtual device.