Changeset c2f0160 in mainline for uspace/srv/bd

Timestamp:

2025-05-06T21:31:40Z (6 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

217d0fb

Parents:

d1d355f

Message:

hr: util: add more checks for hotspare addition

File:

• uspace/srv/bd/hr/util.c (modified) (2 diffs)

uspace/srv/bd/hr/util.c

@@ -1018 +1018 @@
         }
 
+        for (size_t i = 0; i < vol->hotspare_no; i++) {
+                if (vol->hotspares[i].svc_id == hotspare) {
+                        HR_ERROR("%s(): hotspare (%" PRIun ") already used in "
+                            "%s\n", __func__, hotspare, vol->devname);
+                        rc = EEXIST;
+                        goto error;
+                }
+        }
+
         rc = block_init(hotspare);
         if (rc != EOK)
@@ -1029 +1038 @@
         }
 
-        if (hs_blkno < vol->truncated_blkno - vol->meta_ops->get_size()) {
+        if (hs_blkno - vol->meta_ops->get_size() < vol->truncated_blkno) {
+                HR_ERROR("%s(): hotspare (%" PRIun ") doesn't have enough "
+                    "blocks\n", __func__, hotspare);
+
                 rc = EINVAL;
                 block_fini(hotspare);